Skip to content

genjavadoc plugin breaking publish nightly job #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pjfanning opened this issue Jan 13, 2025 · 7 comments
Closed

genjavadoc plugin breaking publish nightly job #1706

pjfanning opened this issue Jan 13, 2025 · 7 comments
Assignees

Comments

@pjfanning
Copy link
Contributor

Not yet published for Scala 2.13.16

https://github.com/apache/pekko/actions/runs/12728852719/job/35479939070

@raboof raboof self-assigned this Jan 13, 2025
@raboof
Copy link
Member

raboof commented Jan 13, 2025

lightbend/genjavadoc#376

@raboof
Copy link
Member

raboof commented Jan 13, 2025

earlier we'd have caught this in #1704 because the link validator also runs with genjavadoc, but we moved that to nightly. Perhaps we should enabled it in one of the sbt invocations in binary-compatibility-checks.yml?

@pjfanning
Copy link
Contributor Author

I just think in future, we shouldn't manually update Scala. We should wait for Scala Steward. It appears to have some set up that holds it back from recommending Scala updates until the sbt tooling catches up.

@He-Pin
Copy link
Member

He-Pin commented Jan 13, 2025

Not sure why genjavadoc need be updated for every scala release.

@raboof
Copy link
Member

raboof commented Jan 13, 2025

Not sure why genjavadoc need be updated for every scala release.

Because it hooks into compiler internals that may change between Scala releases, so may need changes between them. Such changes are not always needed, but they're erring on the safe side.

@pjfanning
Copy link
Contributor Author

Our builds in other Pekko repos are also affected. The main branch snapshots now have a dependency on scala-library 2.13.16 and sbt blows up when the scala version is less than the transitive dependency version of scala-library.

eg https://github.com/apache/pekko-connectors-kafka/actions/runs/12759834551/job/35564242431

I am tempted to revert #1704 and reapply it when we start seeing scala steward updating the downstream repos.

@He-Pin
Copy link
Member

He-Pin commented Jan 17, 2025

It's been released, and is now green.

@He-Pin He-Pin closed this as completed Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants