From 9d9e165616be1d46a7adb71145ed2905cab91b36 Mon Sep 17 00:00:00 2001 From: GLBB Date: Sat, 4 Jun 2022 17:51:26 +0800 Subject: [PATCH] remove useless check --- .../common/message/MessageDecoder.java | 26 +++++++++---------- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java b/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java index 7612ef40436..b86780f7dc3 100644 --- a/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java +++ b/common/src/main/java/org/apache/rocketmq/common/message/MessageDecoder.java @@ -428,22 +428,20 @@ public static String messageProperties2String(Map properties) { len += 2; // separator } StringBuilder sb = new StringBuilder(len); - if (properties != null) { - for (final Map.Entry entry : properties.entrySet()) { - final String name = entry.getKey(); - final String value = entry.getValue(); + for (final Map.Entry entry : properties.entrySet()) { + final String name = entry.getKey(); + final String value = entry.getValue(); - if (value == null) { - continue; - } - sb.append(name); - sb.append(NAME_VALUE_SEPARATOR); - sb.append(value); - sb.append(PROPERTY_SEPARATOR); - } - if (sb.length() > 0) { - sb.deleteCharAt(sb.length() - 1); + if (value == null) { + continue; } + sb.append(name); + sb.append(NAME_VALUE_SEPARATOR); + sb.append(value); + sb.append(PROPERTY_SEPARATOR); + } + if (sb.length() > 0) { + sb.deleteCharAt(sb.length() - 1); } return sb.toString(); }