chore: todo improvement

soyuka · soyuka · commit 757bcbb586c9 · 2025-07-03T14:51:40.000+02:00
diff --git a/src/Laravel/Controller/ApiPlatformController.php b/src/Laravel/Controller/ApiPlatformController.php
@@ -103,6 +103,7 @@ private function getUriVariables(Request $request, HttpOperation $operation): ar
     {
         $uriVariables = [];
         foreach ($operation->getUriVariables() ?? [] as $parameterName => $_) {
+            // TODO: use $link->getParameterName() instead but be sure it is filled correctly in metadata fist
             $parameter = $request->route((string) $parameterName);
             if (\is_string($parameter) && ($format = $request->attributes->get('_format')) && str_contains($parameter, $format)) {
                 $parameter = substr($parameter, 0, \strlen($parameter) - (\strlen($format) + 1));

Original file line number	Diff line number	Diff line change
`@@ -103,6 +103,7 @@ private function getUriVariables(Request $request, HttpOperation $operation): ar`
`103`	`103`	`{`
`104`	`104`	`$uriVariables = [];`
`105`	`105`	`foreach ($operation->getUriVariables() ?? [] as $parameterName => $_) {`
	`106`	`+ // TODO: use $link->getParameterName() instead but be sure it is filled correctly in metadata fist`
`106`	`107`	`$parameter = $request->route((string) $parameterName);`
`107`	`108`	`if (\is_string($parameter) && ($format = $request->attributes->get('_format')) && str_contains($parameter, $format)) {`
`108`	`109`	`$parameter = substr($parameter, 0, \strlen($parameter) - (\strlen($format) + 1));`