Skip to content

Commit adb81fd

Browse files
committed
[Swagger] Do not tag an sub-resource operation with child resource
1 parent 0218f78 commit adb81fd

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/Swagger/Serializer/DocumentationNormalizer.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,11 @@ public function normalize($object, $format = null, array $context = [])
127127
$responseDefinitionKey = $this->getDefinition($definitions, $subResourceMetadata, $subresourceOperation['resource_class'], $serializerContext);
128128

129129
$pathOperation = new \ArrayObject([]);
130-
$pathOperation['tags'] = $subresourceOperation['shortNames'];
130+
if (isset($subresourceOperation['shortNames'][1])) {
131+
$pathOperation['tags'] = [$subresourceOperation['shortNames'][1]];
132+
} else {
133+
$pathOperation['tags'] = [$subresourceOperation['shortNames'][0]];
134+
}
131135
$pathOperation['operationId'] = $operationId;
132136
$pathOperation['produces'] = $mimeTypes;
133137
$pathOperation['summary'] = sprintf('Retrieves %s%s resource%s.', $subresourceOperation['collection'] ? 'the collection of ' : 'a ', $subresourceOperation['shortNames'][0], $subresourceOperation['collection'] ? 's' : '');

tests/Swagger/Serializer/DocumentationNormalizerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1735,7 +1735,7 @@ public function testNormalizeWithSubResource()
17351735
],
17361736
'/api/questions/{id}/answer' => new \ArrayObject([
17371737
'get' => new \ArrayObject([
1738-
'tags' => ['Answer', 'Question'],
1738+
'tags' => ['Question'],
17391739
'operationId' => 'api_questions_answer_get_subresource',
17401740
'produces' => ['application/ld+json'],
17411741
'summary' => 'Retrieves a Answer resource.',

0 commit comments

Comments
 (0)