Skip to content

Commit d7a5d54

Browse files
ttskchttskch
authored
cs: remove unnecessary comments (#6408)
1 parent ea7d443 commit d7a5d54

File tree

13 files changed

+0
-36
lines changed

13 files changed

+0
-36
lines changed

‎src/JsonSchema/Command/JsonSchemaGenerateCommand.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
*/
3232
final class JsonSchemaGenerateCommand extends Command
3333
{
34-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
3534
private array $formats;
3635

3736
public function __construct(private readonly SchemaFactoryInterface $schemaFactory, array $formats)

‎src/JsonSchema/Tests/SchemaFactoryTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ public function testBuildSchemaForNonResourceClass(): void
9191
$definitions = $resultSchema->getDefinitions();
9292

9393
$this->assertSame((new \ReflectionClass(NotAResource::class))->getShortName(), $rootDefinitionKey);
94-
// @noRector
9594
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
9695
$this->assertArrayHasKey('type', $definitions[$rootDefinitionKey]);
9796
$this->assertSame('object', $definitions[$rootDefinitionKey]['type']);
@@ -168,7 +167,6 @@ public function testBuildSchemaForNonResourceClassWithUnionIntersectTypes(): voi
168167
$definitions = $resultSchema->getDefinitions();
169168

170169
$this->assertSame((new \ReflectionClass(NotAResourceWithUnionIntersectTypes::class))->getShortName(), $rootDefinitionKey);
171-
// @noRector
172170
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
173171
$this->assertArrayHasKey('type', $definitions[$rootDefinitionKey]);
174172
$this->assertSame('object', $definitions[$rootDefinitionKey]['type']);
@@ -252,7 +250,6 @@ public function testBuildSchemaWithSerializerGroups(): void
252250
$definitions = $resultSchema->getDefinitions();
253251

254252
$this->assertSame((new \ReflectionClass(OverriddenOperationDummy::class))->getShortName().'-'.$serializerGroup, $rootDefinitionKey);
255-
// @noRector
256253
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
257254
$this->assertArrayHasKey('type', $definitions[$rootDefinitionKey]);
258255
$this->assertSame('object', $definitions[$rootDefinitionKey]['type']);
@@ -311,7 +308,6 @@ public function testBuildSchemaForAssociativeArray(): void
311308
$definitions = $resultSchema->getDefinitions();
312309

313310
$this->assertSame((new \ReflectionClass(NotAResource::class))->getShortName(), $rootDefinitionKey);
314-
// @noRector
315311
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
316312
$this->assertArrayHasKey('properties', $definitions[$rootDefinitionKey]);
317313
$this->assertArrayHasKey('foo', $definitions[$rootDefinitionKey]['properties']);

‎src/JsonSchema/Tests/SchemaTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,10 @@ public function testDefinitions(string $version, array $baseDefinitions): void
7373
if (Schema::VERSION_OPENAPI === $version) {
7474
$this->assertArrayHasKey('schemas', $schema['components']);
7575
} else {
76-
// @noRector
7776
$this->assertTrue(isset($schema['definitions']));
7877
}
7978

8079
$definitions = $schema->getDefinitions();
81-
// @noRector
8280
$this->assertTrue(isset($definitions['foo']));
8381

8482
$this->assertArrayNotHasKey('definitions', $schema->getArrayCopy(false));

‎src/Metadata/Tests/Resource/Factory/AttributesResourceMetadataCollectionFactoryTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ class: AttributeResource::class,
9595
priority: 4,
9696
status: 301,
9797
provider: AttributeResourceProvider::class,
98-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
9998
processor: [AttributeResourceProcessor::class, 'process']
10099
),
101100
'_api_/dummy/{dummyId}/attribute_resources/{identifier}{._format}_patch' => new Patch(
@@ -106,14 +105,12 @@ class: AttributeResource::class,
106105
priority: 5,
107106
status: 301,
108107
provider: AttributeResourceProvider::class,
109-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
110108
processor: [AttributeResourceProcessor::class, 'process']
111109
),
112110
],
113111
inputFormats: ['json' => ['application/merge-patch+json']],
114112
status: 301,
115113
provider: AttributeResourceProvider::class,
116-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
117114
processor: [AttributeResourceProcessor::class, 'process']
118115
),
119116
]),

‎src/Serializer/AbstractCollectionNormalizer.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ abstract class AbstractCollectionNormalizer implements NormalizerInterface, Norm
4040
/**
4141
* This constant must be overridden in the child class.
4242
*/
43-
// @noRector \Rector\Php81\Rector\ClassConst\FinalizePublicClassConstantRector
4443
public const FORMAT = 'to-override';
4544

4645
public function __construct(protected ResourceClassResolverInterface|LegacyResourceClassResolverInterface $resourceClassResolver, protected string $pageParameterName, protected ?ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null)

‎src/Serializer/JsonEncoder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
*/
2727
final class JsonEncoder implements EncoderInterface, DecoderInterface
2828
{
29-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
3029
public function __construct(private readonly string $format, private ?BaseJsonEncoder $jsonEncoder = null)
3130
{
3231
if (null !== $this->jsonEncoder) {

‎src/Symfony/Bundle/DependencyInjection/Compiler/ElasticsearchClientPass.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,8 @@ public function process(ContainerBuilder $container): void
5757
$clientDefinition = $container->getDefinition('api_platform.elasticsearch.client');
5858

5959
if (!$clientConfiguration) {
60-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
6160
$clientDefinition->setFactory([$builderName, 'build']);
6261
} else {
63-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
6462
$clientDefinition->setFactory([$builderName, 'fromConfig']);
6563
$clientDefinition->setArguments([$clientConfiguration]);
6664
}

‎tests/Behat/DoctrineContext.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,11 +224,8 @@
224224
*/
225225
final class DoctrineContext implements Context
226226
{
227-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
228227
private ObjectManager $manager;
229-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
230228
private ?SchemaTool $schemaTool;
231-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
232229
private ?SchemaManager $schemaManager;
233230

234231
/**

‎tests/Fixtures/TestBundle/Entity/Content.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class Content implements \JsonSerializable
3737
#[ORM\OrderBy(['id' => 'ASC'])]
3838
private Collection|iterable $fields;
3939
#[ORM\Column(type: 'string')]
40-
// @noRector \Rector\Php81\Rector\Property\ReadOnlyPropertyRector
4140
private string $status = ContentStatus::DRAFT;
4241

4342
public function __construct()

‎tests/Hal/JsonSchema/SchemaFactoryTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,7 @@ public function testHasRootDefinitionKeyBuildSchema(): void
8787
$definitions = $resultSchema->getDefinitions();
8888
$rootDefinitionKey = $resultSchema->getRootDefinitionKey();
8989

90-
// @noRector
9190
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
92-
// @noRector
9391
$this->assertTrue(isset($definitions[$rootDefinitionKey]['properties']));
9492
$properties = $resultSchema['definitions'][$rootDefinitionKey]['properties'];
9593
$this->assertArrayHasKey('_links', $properties);
@@ -118,7 +116,6 @@ public function testSchemaTypeBuildSchema(): void
118116
$definitionName = 'Dummy.jsonhal';
119117

120118
$this->assertNull($resultSchema->getRootDefinitionKey());
121-
// @noRector
122119
$this->assertTrue(isset($resultSchema['properties']));
123120
$this->assertArrayHasKey('_embedded', $resultSchema['properties']);
124121
$this->assertArrayHasKey('totalItems', $resultSchema['properties']);
@@ -130,7 +127,6 @@ public function testSchemaTypeBuildSchema(): void
130127
$resultSchema = $this->schemaFactory->buildSchema(Dummy::class, 'jsonhal', Schema::TYPE_OUTPUT, null, null, null, true);
131128

132129
$this->assertNull($resultSchema->getRootDefinitionKey());
133-
// @noRector
134130
$this->assertTrue(isset($resultSchema['properties']));
135131
$this->assertArrayHasKey('_embedded', $resultSchema['properties']);
136132
$this->assertArrayHasKey('totalItems', $resultSchema['properties']);

‎tests/Hydra/JsonSchema/SchemaFactoryTest.php

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,7 @@ public function testHasRootDefinitionKeyBuildSchema(): void
8686
$definitions = $resultSchema->getDefinitions();
8787
$rootDefinitionKey = $resultSchema->getRootDefinitionKey();
8888

89-
// @noRector
9089
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
91-
// @noRector
9290
$this->assertTrue(isset($definitions[$rootDefinitionKey]['properties']));
9391
$properties = $resultSchema['definitions'][$rootDefinitionKey]['properties'];
9492
$this->assertArrayHasKey('@context', $properties);
@@ -125,9 +123,7 @@ public function testSchemaTypeBuildSchema(): void
125123
$definitionName = 'Dummy.jsonld';
126124

127125
$this->assertNull($resultSchema->getRootDefinitionKey());
128-
// @noRector
129126
$this->assertTrue(isset($resultSchema['properties']));
130-
// @noRector
131127
$this->assertTrue(isset($resultSchema['properties']['hydra:member']));
132128
$this->assertArrayHasKey('hydra:totalItems', $resultSchema['properties']);
133129
$this->assertArrayHasKey('hydra:view', $resultSchema['properties']);
@@ -140,9 +136,7 @@ public function testSchemaTypeBuildSchema(): void
140136
$resultSchema = $this->schemaFactory->buildSchema(Dummy::class, 'jsonld', Schema::TYPE_OUTPUT, null, null, null, true);
141137

142138
$this->assertNull($resultSchema->getRootDefinitionKey());
143-
// @noRector
144139
$this->assertTrue(isset($resultSchema['properties']));
145-
// @noRector
146140
$this->assertTrue(isset($resultSchema['properties']['hydra:member']));
147141
$this->assertArrayHasKey('hydra:totalItems', $resultSchema['properties']);
148142
$this->assertArrayHasKey('hydra:view', $resultSchema['properties']);
@@ -158,9 +152,7 @@ public function testHasHydraViewNavigationBuildSchema(): void
158152
$resultSchema = $this->schemaFactory->buildSchema(Dummy::class, 'jsonld', Schema::TYPE_OUTPUT, new GetCollection());
159153

160154
$this->assertNull($resultSchema->getRootDefinitionKey());
161-
// @noRector
162155
$this->assertTrue(isset($resultSchema['properties']));
163-
// @noRector
164156
$this->assertTrue(isset($resultSchema['properties']['hydra:view']));
165157
$this->assertArrayHasKey('properties', $resultSchema['properties']['hydra:view']);
166158
$this->assertArrayHasKey('hydra:first', $resultSchema['properties']['hydra:view']['properties']);

‎tests/JsonApi/JsonSchema/SchemaFactoryTest.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,7 @@ public function testHasRootDefinitionKeyBuildSchema(): void
9898
$definitions = $resultSchema->getDefinitions();
9999
$rootDefinitionKey = $resultSchema->getRootDefinitionKey();
100100

101-
// @noRector
102101
$this->assertTrue(isset($definitions[$rootDefinitionKey]));
103-
// @noRector
104102
$this->assertTrue(isset($definitions[$rootDefinitionKey]['properties']));
105103
$properties = $resultSchema['definitions'][$rootDefinitionKey]['properties'];
106104
$this->assertArrayHasKey('data', $properties);
@@ -135,7 +133,6 @@ public function testSchemaTypeBuildSchema(): void
135133
$definitionName = 'Dummy.jsonapi';
136134

137135
$this->assertNull($resultSchema->getRootDefinitionKey());
138-
// @noRector
139136
$this->assertTrue(isset($resultSchema['properties']));
140137
$this->assertArrayHasKey('links', $resultSchema['properties']);
141138
$this->assertArrayHasKey('self', $resultSchema['properties']['links']['properties']);
@@ -163,7 +160,6 @@ public function testSchemaTypeBuildSchema(): void
163160
$resultSchema = $this->schemaFactory->buildSchema(Dummy::class, 'jsonapi', Schema::TYPE_OUTPUT, forceCollection: true);
164161

165162
$this->assertNull($resultSchema->getRootDefinitionKey());
166-
// @noRector
167163
$this->assertTrue(isset($resultSchema['properties']));
168164
$this->assertArrayHasKey('links', $resultSchema['properties']);
169165
$this->assertArrayHasKey('self', $resultSchema['properties']['links']['properties']);

‎tests/Symfony/Bundle/DependencyInjection/Compiler/ElasticsearchClientPassTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ public function testProcess(): void
5656
}
5757

5858
$clientDefinitionProphecy = $this->prophesize(Definition::class);
59-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
6059
$clientDefinitionProphecy->setFactory([$clientBuilder, 'fromConfig'])->willReturn($clientDefinitionProphecy->reveal())->shouldBeCalled();
6160
$clientDefinitionProphecy->setArguments(
6261
Argument::allOf(
@@ -79,7 +78,6 @@ public function testProcessWithoutConfiguration(): void
7978
$clientBuilder = class_exists(\Elasticsearch\ClientBuilder::class) ? \Elasticsearch\ClientBuilder::class : \Elastic\Elasticsearch\ClientBuilder::class;
8079

8180
$clientDefinitionProphecy = $this->prophesize(Definition::class);
82-
// @noRector \Rector\Php81\Rector\Array_\FirstClassCallableRector
8381
$clientDefinitionProphecy->setFactory([$clientBuilder, 'build'])->willReturn($clientDefinitionProphecy->reveal())->shouldBeCalled();
8482

8583
$containerBuilderProphecy = $this->prophesize(ContainerBuilder::class);

0 commit comments

Comments
 (0)