Ensure no empty fatal error messages

milseman · milseman · commit 8a4243387e5d · 2021-01-31T08:55:50.000-07:00
diff --git a/Tests/SystemTests/FileOperationsTest.swift b/Tests/SystemTests/FileOperationsTest.swift
@@ -108,7 +108,7 @@ final class FileOperationsTest: XCTestCase {
       // Should we assert? I'd be interested in knowing if this happened
       XCTAssert(false)
     } catch {
-       fatalError()
+      fatalError("FATAL: `testAdHocOpen`")
     }
   }
 }
diff --git a/Tests/SystemTests/TestingInfrastructure.swift b/Tests/SystemTests/TestingInfrastructure.swift
@@ -92,7 +92,7 @@ extension TestCase {
   func fail(_ reason: String? = nil) {
     XCTAssert(false, failureMessage(reason), file: file, line: line)
     if forceFatalFailures {
-      fatalError(reason ?? "")
+      fatalError(reason ?? "<no reason>")
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ final class FileOperationsTest: XCTestCase {`
`108`	`108`	`// Should we assert? I'd be interested in knowing if this happened`
`109`	`109`	`XCTAssert(false)`
`110`	`110`	`} catch {`
`111`		`- fatalError()`
	`111`	+ fatalError("FATAL: `testAdHocOpen`")
`112`	`112`	`}`
`113`	`113`	`}`
`114`	`114`	`}`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ extension TestCase {`
`92`	`92`	`func fail(_ reason: String? = nil) {`
`93`	`93`	`XCTAssert(false, failureMessage(reason), file: file, line: line)`
`94`	`94`	`if forceFatalFailures {`
`95`		`- fatalError(reason ?? "")`
	`95`	`+ fatalError(reason ?? "<no reason>")`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`