Skip to content

fix: don't use scope for trivy registry login command #8393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

DockerHub returns error when we use scope (see #8386 ).
So we need to use empty scope to fix this error.

We can confirm that it works for DockerHub, GHCR (#8386 (comment)).

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263
Copy link
Collaborator

I tested with ECR.

$ aws ecr get-login-password | ./trivy registry login --username AWS --password-stdin <0123456789>.dkr.ecr.eu-central-1.amazonaws.com

@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 13, 2025 08:36
@knqyf263 knqyf263 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into aquasecurity:main with commit 8715e5d Feb 13, 2025
12 checks passed
RingoDev pushed a commit to RingoDev/trivy that referenced this pull request Feb 26, 2025
dstrelbytskyi pushed a commit to datarobot/trivy that referenced this pull request Mar 5, 2025
dstrelbytskyi pushed a commit to datarobot/trivy that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trivy registry login fails for docker.io with "unknown resource type" error
2 participants