From 993eb3eeb72cf92f57cde2a174bdfd9eac862e1e Mon Sep 17 00:00:00 2001 From: per1234 Date: Thu, 28 May 2020 11:18:12 -0700 Subject: [PATCH] Remove obsolete workaround for ESP8266 in compilation test CI workflow The ESP8266 platform has a tool dependency on python3, but assumes that tool is already installed in a particular location on Linux. At the time this workaround was added, the Docker container used by the arduino/actions/libraries/compile-examples action did not provide this tool, so a workaround was needed to install it in the container. Since that time, the action has developed a dependency on Python, making this workaround unnecessary. The switch from the action being a Bash script to a Python script caused the now-unnecessary workaround to break the workflow. --- .github/workflows/compile-examples.yml | 7 ------- .github/workflows/install-python-wrapper.sh | 9 --------- 2 files changed, 16 deletions(-) delete mode 100755 .github/workflows/install-python-wrapper.sh diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml index 7aab170..11d8047 100644 --- a/.github/workflows/compile-examples.yml +++ b/.github/workflows/compile-examples.yml @@ -21,14 +21,7 @@ jobs: with: fetch-depth: 1 - name: compile-examples for official Arduino boards - if: startsWith(matrix.fqbn, '"esp8266:esp8266') != true uses: arduino/actions/libraries/compile-examples@master with: fqbn: ${{ matrix.fqbn }} libraries: ${{ env.LIBRARIES }} - - name: compile-examples for ESP8266 boards - if: startsWith(matrix.fqbn, '"esp8266:esp8266') - uses: arduino/actions/libraries/compile-examples@master - with: - fqbn: ${{ matrix.fqbn }} - entrypoint: /github/workspace/.github/workflows/install-python-wrapper.sh diff --git a/.github/workflows/install-python-wrapper.sh b/.github/workflows/install-python-wrapper.sh deleted file mode 100755 index 6d818f8..0000000 --- a/.github/workflows/install-python-wrapper.sh +++ /dev/null @@ -1,9 +0,0 @@ -#!/bin/bash -x -# This script is used as an alternate entrypoint to allow installing Python 3 (a dependency of -# the ESP8266 core for Arduino) in the Docker container used by the compile-examples action - -# Install Python 3 -apt-get update && apt-get install -y python3 - -# Run the standard entrypoint script -/entrypoint.sh "$@"