Skip to content

Commit b4bcb30

Browse files
authored
Merge pull request #9262 from joew46167/master
Add titles to rows in the manager tables
2 parents 923a75c + 227bae4 commit b4bcb30

File tree

2 files changed

+15
-27
lines changed

2 files changed

+15
-27
lines changed

app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellJPanel.java

+7-13
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,12 @@
33
import static processing.app.I18n.format;
44
import static processing.app.I18n.tr;
55

6-
import java.awt.Color;
7-
import java.awt.Component;
8-
import java.awt.Dimension;
9-
import java.awt.Insets;
6+
import java.awt.*;
107
import java.util.Optional;
118

12-
import javax.swing.Box;
13-
import javax.swing.BoxLayout;
14-
import javax.swing.JButton;
15-
import javax.swing.JComboBox;
16-
import javax.swing.JLabel;
17-
import javax.swing.JPanel;
18-
import javax.swing.JTable;
19-
import javax.swing.JTextPane;
9+
import javax.swing.*;
2010
import javax.swing.border.EmptyBorder;
11+
import javax.swing.border.TitledBorder;
2112
import javax.swing.event.HyperlinkEvent;
2213
import javax.swing.text.Document;
2314
import javax.swing.text.html.HTMLDocument;
@@ -128,6 +119,9 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
128119
return;
129120

130121
ContributedLibrary selected = releases.getSelected();
122+
TitledBorder titledBorder = BorderFactory.createTitledBorder(selected.getName());
123+
titledBorder.setTitleFont(getFont().deriveFont(Font.BOLD));
124+
setBorder(titledBorder);
131125
Optional<ContributedLibrary> mayInstalled = releases.getInstalled();
132126

133127
boolean installable, upgradable;
@@ -162,7 +156,7 @@ public ContributedLibraryTableCellJPanel(JTable parentTable, Object value,
162156
String desc = "<html><body>";
163157

164158
// Library name...
165-
desc += format("<b>{0}</b>", name);
159+
// desc += format("<b>{0}</b>", name);
166160
if (mayInstalled.isPresent() && mayInstalled.get().isIDEBuiltIn()) {
167161
desc += " Built-In ";
168162
}

app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellJPanel.java

+8-14
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,11 @@
3232
import static processing.app.I18n.format;
3333
import static processing.app.I18n.tr;
3434

35-
import java.awt.Color;
36-
import java.awt.Component;
37-
import java.awt.Dimension;
38-
import java.awt.Insets;
39-
40-
import javax.swing.Box;
41-
import javax.swing.BoxLayout;
42-
import javax.swing.JButton;
43-
import javax.swing.JComboBox;
44-
import javax.swing.JLabel;
45-
import javax.swing.JPanel;
46-
import javax.swing.JTable;
47-
import javax.swing.JTextPane;
35+
import java.awt.*;
36+
37+
import javax.swing.*;
4838
import javax.swing.border.EmptyBorder;
39+
import javax.swing.border.TitledBorder;
4940
import javax.swing.event.HyperlinkEvent;
5041
import javax.swing.text.Document;
5142
import javax.swing.text.html.HTMLDocument;
@@ -196,6 +187,9 @@ void update(JTable parentTable, Object value, boolean isSelected,
196187
}
197188

198189
ContributedPlatform selected = releases.getSelected();
190+
TitledBorder titledBorder = BorderFactory.createTitledBorder(selected.getName());
191+
titledBorder.setTitleFont(getFont().deriveFont(Font.BOLD));
192+
setBorder(titledBorder);
199193
ContributedPlatform installed = releases.getInstalled();
200194

201195
boolean removable, installable, upgradable;
@@ -221,7 +215,7 @@ void update(JTable parentTable, Object value, boolean isSelected,
221215
removeButtonPlaceholder.setVisible(!removable);
222216

223217
String desc = "<html><body>";
224-
desc += "<b>" + selected.getName() + "</b>";
218+
// desc += "<b>" + selected.getName() + "</b>";
225219
if (installed != null && installed.isBuiltIn()) {
226220
desc += " Built-In ";
227221
}

0 commit comments

Comments
 (0)