Skip to content

SE05x KeyID is not correctly encoded into the private key reference #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lagosantol opened this issue Dec 20, 2023 · 0 comments · Fixed by #217
Closed

SE05x KeyID is not correctly encoded into the private key reference #216

lagosantol opened this issue Dec 20, 2023 · 0 comments · Fixed by #217
Assignees
@pennam
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@lagosantol
Copy link
Contributor

The issue is in this line:

ArduinoCore-renesas/libraries/SSLClient/src/SSLClient.cpp

Line 380 in c0f158f

key[28] = KeySlot;

Only the least significant byte of the key ID is stored.
The key ID should be stored in 4 bytes, big endian.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 20, 2023
@pennam pennam mentioned this issue Dec 20, 2023
Closed
@per1234 per1234 linked a pull request Dec 20, 2023 that will close this issue
Fixed encoding of KeySlot ID. #217
Merged
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pennam pennam

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
3 participants
@per1234 @pennam @lagosantol