Add core ID in outdated command output (#1406)

Author: silvanocerza

cli/outdated/outdated.go

@@ -59,10 +59,10 @@ func runOutdatedCommand(cmd *cobra.Command, args []string) {
 
 	// Prints outdated cores
 	tab := table.New()
-	tab.SetHeader(tr("Core name"), tr("Installed version"), tr("New version"))
+	tab.SetHeader(tr("ID"), tr("Installed version"), tr("New version"), tr("Name"))
 	if len(outdatedResp.OutdatedPlatforms) > 0 {
 		for _, p := range outdatedResp.OutdatedPlatforms {
-			tab.AddRow(p.Name, p.Installed, p.Latest)
+			tab.AddRow(p.Id, p.Installed, p.Latest, p.Name)
 		}
 		feedback.Print(tab.Render())
 	}

commands/core/list.go

@@ -16,6 +16,7 @@
 package core
 
 import (
+	"fmt"
 	"sort"
 	"strings"
 
@@ -58,14 +59,20 @@ func GetPlatforms(req *rpc.PlatformListRequest) ([]*rpc.Platform, error) {
 			}
 
 			if platformRelease != nil {
+				latest := platform.GetLatestRelease()
+				if latest == nil {
+					return nil, fmt.Errorf(tr("can't find latest release of core %s", platform))
+				}
+
 				if req.UpdatableOnly {
-					if latest := platform.GetLatestRelease(); latest == nil || latest == platformRelease {
+					if latest == platformRelease {
 						continue
 					}
 				}
 
 				rpcPlatform := commands.PlatformReleaseToRPC(platformRelease)
 				rpcPlatform.Installed = platformRelease.Version.String()
+				rpcPlatform.Latest = latest.Version.String()
 				res = append(res, rpcPlatform)
 			}
 		}

i18n/data/en.po

@@ -378,7 +378,6 @@ msgstr "Connected"
 msgid "Core"
 msgstr "Core"
 
-#: cli/outdated/outdated.go:62
 #: cli/update/update.go:99
 msgid "Core name"
 msgstr "Core name"
@@ -914,6 +913,7 @@ msgstr "Global variables use {0} bytes of dynamic memory."
 
 #: cli/core/list.go:84
 #: cli/core/search.go:114
+#: cli/outdated/outdated.go:62
 msgid "ID"
 msgstr "ID"
 
@@ -1192,6 +1192,7 @@ msgstr "Multiple libraries were found for \"{0}\""
 #: cli/core/list.go:84
 #: cli/core/search.go:114
 #: cli/lib/list.go:125
+#: cli/outdated/outdated.go:62
 msgid "Name"
 msgstr "Name"
 
@@ -2128,6 +2129,10 @@ msgstr "can't find dependencies for platform %[1]s: %[2]w"
 msgid "can't find latest release of %s"
 msgstr "can't find latest release of %s"
 
+#: commands/core/list.go:64
+msgid "can't find latest release of core %s"
+msgstr "can't find latest release of core %s"
+
 #: arduino/sketch/sketch.go:101
 msgid "can't find main Sketch file in %s"
 msgstr "can't find main Sketch file in %s"
@@ -2629,7 +2634,7 @@ msgstr "invalid hash '%[1]s': %[2]s"
 #: commands/compile/compile.go:93
 #: commands/core/download.go:36
 #: commands/core/install.go:35
-#: commands/core/list.go:38
+#: commands/core/list.go:39
 #: commands/core/search.go:40
 #: commands/core/uninstall.go:33
 #: commands/core/upgrade.go:40
@@ -3309,7 +3314,7 @@ msgstr "unable to create a folder to save the sketch files"
 msgid "unable to create the folder containing the item"
 msgstr "unable to create the folder containing the item"
 
-#: commands/core/list.go:33
+#: commands/core/list.go:34
 msgid "unable to find an instance with ID: %d"
 msgstr "unable to find an instance with ID: %d"
 

i18n/rice-box.go

@@ -23,6 +23,7 @@
 import hashlib
 from git import Repo
 from pathlib import Path
+import semver
 
 
 def test_core_search(run_command, httpserver):
@@ -753,3 +754,21 @@ def test_core_with_missing_custom_board_options_is_loaded(run_command, data_dir)
         + "skipping loading of boards arduino-beta-dev:platform_with_missing_custom_board_options:nessuno: "
         + "malformed custom board options"
     ) in res.stderr
+
+
+def test_core_list_outdated_core(run_command):
+    assert run_command("update")
+
+    # Install an old core version
+    assert run_command("core install arduino:[email protected]")
+
+    res = run_command("core list --format json")
+
+    data = json.loads(res.stdout)
+    assert len(data) == 1
+    samd_core = data[0]
+    assert samd_core["installed"] == "1.8.6"
+    installed_version = semver.parse_version_info(samd_core["installed"])
+    latest_version = semver.parse_version_info(samd_core["latest"])
+    # Installed version must be older than latest
+    assert installed_version.compare(latest_version) == -1

test/test_core.py

@@ -33,8 +33,8 @@ def test_outdated(run_command):
     result = run_command("outdated")
     assert result.ok
     lines = [l.strip() for l in result.stdout.splitlines()]
-    assert lines[1].startswith("Arduino AVR Boards")
-    assert lines[4].startswith("USBHost")
+    assert "Arduino AVR Boards" in lines[1]
+    assert "USBHost" in lines[4]
 
 
 def test_outdated_using_library_with_invalid_version(run_command, data_dir):

test/test_outdated.py

@@ -33,8 +33,8 @@ def test_upgrade(run_command):
     result = run_command("outdated")
     assert result.ok
     lines = result.stdout.splitlines()
-    assert lines[1].startswith("Arduino AVR Boards")
-    assert lines[4].startswith("USBHost")
+    assert "Arduino AVR Boards" in lines[1]
+    assert "USBHost" in lines[4]
 
     result = run_command("upgrade")
     assert result.ok