Skip to content

Commit 3849a27

Browse files
committed
skip test failing on macOS and on win and optimize the test
1 parent db987b9 commit 3849a27

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

test/test_core.py

+10-5
Original file line numberDiff line numberDiff line change
@@ -689,6 +689,12 @@ def test_core_list_platform_without_platform_txt(run_command, data_dir):
689689
assert core["name"] == "some-packager-some-arch"
690690

691691

692+
@pytest.mark.skipif(
693+
platform.system() in ["Darwin", "Windows"],
694+
reason="macOS by default is case insensitive https://github.com/actions/virtual-environments/issues/865 "
695+
+ "Windows too is case insensitive"
696+
+ "https://stackoverflow.com/questions/7199039/file-paths-in-windows-environment-not-case-sensitive",
697+
)
692698
def test_core_download_multiple_platforms(run_command, data_dir):
693699
assert run_command(["update"])
694700

@@ -705,11 +711,10 @@ def test_core_download_multiple_platforms(run_command, data_dir):
705711
boards_txt.touch()
706712
assert boards_txt.write_bytes(test_boards_txt.read_bytes())
707713

708-
test_boards_txt = Path(__file__).parent / "testdata" / "boards.local.txt"
709-
boards_txt = Path(data_dir, "packages", "packager", "hardware", "arch", "1.0.0", "boards.txt")
710-
boards_txt.parent.mkdir(parents=True, exist_ok=True)
711-
boards_txt.touch()
712-
assert boards_txt.write_bytes(test_boards_txt.read_bytes())
714+
boards_txt1 = Path(data_dir, "packages", "packager", "hardware", "arch", "1.0.0", "boards.txt")
715+
boards_txt1.parent.mkdir(parents=True, exist_ok=True)
716+
boards_txt1.touch()
717+
assert boards_txt1.write_bytes(test_boards_txt.read_bytes())
713718

714719
# Verifies the two cores are detected
715720
res = run_command(["core", "list", "--format", "json"])

0 commit comments

Comments
 (0)