Skip to content

Commit b702e75

Browse files
cmaglieumbynos
andauthored
Apply suggestions from code review
Co-authored-by: Umberto Baldi <[email protected]>
1 parent f645fe8 commit b702e75

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

executils/process.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ func (p *Process) StdinPipe() (io.WriteCloser, error) {
8888
// output when the command starts.
8989
//
9090
// Wait will close the pipe after seeing the command exit, so most callers
91-
// need not close the pipe themselves. It is thus incorrect to call Wait
91+
// don't need to close the pipe themselves. It is thus incorrect to call Wait
9292
// before all reads from the pipe have completed.
9393
// For the same reason, it is incorrect to call Run when using StdoutPipe.
9494
func (p *Process) StdoutPipe() (io.ReadCloser, error) {
@@ -99,7 +99,7 @@ func (p *Process) StdoutPipe() (io.ReadCloser, error) {
9999
// error when the command starts.
100100
//
101101
// Wait will close the pipe after seeing the command exit, so most callers
102-
// need not close the pipe themselves. It is thus incorrect to call Wait
102+
// don't need to close the pipe themselves. It is thus incorrect to call Wait
103103
// before all reads from the pipe have completed.
104104
// For the same reason, it is incorrect to use Run when using StderrPipe.
105105
func (p *Process) StderrPipe() (io.ReadCloser, error) {

0 commit comments

Comments
 (0)