Skip to content

Commit b9139e6

Browse files
committed
Fixed regexp for loader detection and do not add incompatible loaders to the output
1 parent ff77f91 commit b9139e6

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

utils/utils.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ func GetCompatibleWith(name string) map[string][]firmware {
4040

4141
knownBoards := make(map[string]combo)
4242
knownBoards["mkr1000"] = combo{match: "(WINC1500)*(3a0)", loader: "WINC1500/Firmware*"}
43-
knownBoards["mkrwifi1010"] = combo{match: "(NINA)", loader: "NINA/Firmware*(mkrwifi)*", avoid: "uno"}
44-
knownBoards["nano_33_iot"] = combo{match: "(NINA)", loader: "NINA/Firmware*(mkrwifi)*", avoid: "uno"}
45-
knownBoards["mkrvidor4000"] = combo{match: "(NINA)", loader: "NINA/Firmware*(mkrvidor)*", avoid: "uno"}
46-
knownBoards["uno2018"] = combo{match: "(NINA)", loader: "NINA/Firmware*(unowifi)*", prefer: "uno", avoid: "mkr"}
43+
knownBoards["mkrwifi1010"] = combo{match: "(NINA)", loader: "NINA/Firmware.*mkrwifi1010.*", avoid: "uno"}
44+
knownBoards["nano_33_iot"] = combo{match: "(NINA)", loader: "NINA/Firmware.*nano_33_iot.*", avoid: "uno"}
45+
knownBoards["mkrvidor4000"] = combo{match: "(NINA)", loader: "NINA/Firmware.*mkrvidor.*", avoid: "uno"}
46+
knownBoards["uno2018"] = combo{match: "(NINA)", loader: "NINA/Firmware.*unowifi.*", prefer: "uno", avoid: "mkr"}
4747
knownBoards["mkrnb1500"] = combo{match: "SARA", loader: "SARA/SerialSARAPassthrough*"}
4848

4949
listAll := false
@@ -74,6 +74,9 @@ func GetCompatibleWith(name string) map[string][]firmware {
7474
lowerPath, _ := filepath.Rel(root, path)
7575
lowerPath = strings.ToLower(lowerPath)
7676
_, alreadyPopulated := files[folder]
77+
if strings.HasPrefix(f.Name, "firmwares") && !f.IsLoader {
78+
return nil
79+
}
7780
if listAll && !strings.HasPrefix(f.Name, "firmwares") {
7881
files[folder] = append(files[folder], f)
7982
}

0 commit comments

Comments
 (0)