fix: theme registration order

Custom theme registration must happen right before restore.

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/theia/monaco/monaco-theming-service.ts

@@ -4,8 +4,7 @@ import { ArduinoThemes } from '../core/theming';
 
 @injectable()
 export class MonacoThemingService extends TheiaMonacoThemingService {
-  override initialize(): void {
-    super.initialize();
+  protected override restore(): Promise<void> {
     const { Light, Dark } = ArduinoThemes;
     this.registerParsedTheme({
       id: Light.id,
@@ -19,5 +18,10 @@ export class MonacoThemingService extends TheiaMonacoThemingService {
       uiTheme: 'vs-dark',
       json: require('../../../../src/browser/data/dark.color-theme.json'),
     });
+    // The custom theme registration must happen before restoring the themes.
+    // Otherwise, the theme content change is not picked up by Theia.
+    // There is a indexedDB getAll before the DB put.
+    // https://github.com/arduino/arduino-ide/issues/1251#issuecomment-1436737702
+    return super.restore();
   }
 }