Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 796aac4

Browse files
author
Akos Kitta
committedMar 29, 2023
fix: propagate monitor errors to the frontend
Closes #1508 Signed-off-by: Akos Kitta <[email protected]>
1 parent 6e72be1 commit 796aac4

File tree

8 files changed

+212
-135
lines changed

8 files changed

+212
-135
lines changed
 

‎arduino-ide-extension/src/browser/monitor-manager-proxy-client-impl.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import {
2+
ApplicationError,
23
CommandRegistry,
34
Disposable,
45
Emitter,
@@ -167,7 +168,13 @@ export class MonitorManagerProxyClientImpl
167168
const { selectedBoard, selectedPort } =
168169
this.boardsServiceProvider.boardsConfig;
169170
if (!selectedBoard || !selectedBoard.fqbn || !selectedPort) return;
170-
await this.server().startMonitor(selectedBoard, selectedPort, settings);
171+
try {
172+
await this.server().startMonitor(selectedBoard, selectedPort, settings);
173+
} catch (err) {
174+
this.messageService.error(
175+
ApplicationError.is(err) ? err.message : String(err)
176+
);
177+
}
171178
}
172179

173180
getCurrentSettings(board: Board, port: Port): Promise<MonitorSettings> {

‎arduino-ide-extension/src/browser/monitor-model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class MonitorModel implements FrontendApplicationContribution {
3939
this._darkTheme = false;
4040
this._wsPort = 0;
4141
this._serialPort = '';
42-
this._connected = true;
42+
this._connected = false;
4343

4444
this.onChangeEmitter = new Emitter<
4545
MonitorModel.State.Change<keyof MonitorModel.State>

‎arduino-ide-extension/src/common/protocol/monitor-service.ts

Lines changed: 95 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Event, JsonRpcServer } from '@theia/core';
1+
import { ApplicationError, Event, JsonRpcServer, nls } from '@theia/core';
22
import {
33
PluggableMonitorSettings,
44
MonitorSettings,
@@ -46,7 +46,7 @@ export interface PluggableMonitorSetting {
4646
readonly id: string;
4747
// A human-readable label of the setting (to be displayed on the GUI)
4848
readonly label: string;
49-
// The setting type (at the moment only "enum" is avaiable)
49+
// The setting type (at the moment only "enum" is available)
5050
readonly type: string;
5151
// The values allowed on "enum" types
5252
readonly values: string[];
@@ -72,24 +72,98 @@ export namespace Monitor {
7272
};
7373
}
7474

75-
export interface Status {}
76-
export type OK = Status;
77-
export interface ErrorStatus extends Status {
78-
readonly message: string;
75+
export const MonitorErrorCodes = {
76+
ConnectionFailed: 6001,
77+
NotConnected: 6002,
78+
AlreadyConnected: 6003,
79+
MissingConfiguration: 6004,
80+
} as const;
81+
82+
export const ConnectionFailedError = createMonitorError(
83+
MonitorErrorCodes.ConnectionFailed
84+
);
85+
export const NotConnectedError = createMonitorError(
86+
MonitorErrorCodes.NotConnected
87+
);
88+
export const AlreadyConnectedError = createMonitorError(
89+
MonitorErrorCodes.AlreadyConnected
90+
);
91+
export const MissingConfigurationError = createMonitorError(
92+
MonitorErrorCodes.MissingConfiguration
93+
);
94+
95+
export function createConnectionFailedError(
96+
port: Port,
97+
details?: string
98+
): ApplicationError<number, PortDescriptor> {
99+
const { protocol, protocolLabel, address, addressLabel } = port;
100+
const formattedDetails = details ? `: ${details}.` : '.';
101+
return ConnectionFailedError(
102+
nls.localize(
103+
'arduino/monitor/connectionFailedError',
104+
'Could not connect to {0} {1} port{2}',
105+
addressLabel,
106+
protocolLabel,
107+
formattedDetails
108+
),
109+
{ protocol, address }
110+
);
79111
}
80-
export namespace Status {
81-
export function isOK(status: Status & { message?: string }): status is OK {
82-
return !!status && typeof status.message !== 'string';
83-
}
84-
export const OK: OK = {};
85-
export const NOT_CONNECTED: ErrorStatus = { message: 'Not connected.' };
86-
export const ALREADY_CONNECTED: ErrorStatus = {
87-
message: 'Already connected.',
88-
};
89-
export const CONFIG_MISSING: ErrorStatus = {
90-
message: 'Serial Config missing.',
91-
};
92-
export const UPLOAD_IN_PROGRESS: ErrorStatus = {
93-
message: 'Upload in progress.',
94-
};
112+
export function createNotConnectedError(
113+
port: Port
114+
): ApplicationError<number, PortDescriptor> {
115+
const { protocol, protocolLabel, address, addressLabel } = port;
116+
return NotConnectedError(
117+
nls.localize(
118+
'arduino/monitor/notConnectedError',
119+
'Not connected to {0} {1} port.',
120+
addressLabel,
121+
protocolLabel
122+
),
123+
{ protocol, address }
124+
);
125+
}
126+
export function createAlreadyConnectedError(
127+
port: Port
128+
): ApplicationError<number, PortDescriptor> {
129+
const { protocol, protocolLabel, address, addressLabel } = port;
130+
return AlreadyConnectedError(
131+
nls.localize(
132+
'arduino/monitor/alreadyConnectedError',
133+
'Could not connect to {0} {1} port. Already connected.',
134+
addressLabel,
135+
protocolLabel
136+
),
137+
{ protocol, address }
138+
);
139+
}
140+
export function createMissingConfigurationError(
141+
port: Port
142+
): ApplicationError<number, PortDescriptor> {
143+
const { protocol, protocolLabel, address, addressLabel } = port;
144+
return MissingConfigurationError(
145+
nls.localize(
146+
'arduino/monitor/missingConfigurationError',
147+
'Could not connect to {0} {1} port. The monitor configuration is missing.',
148+
addressLabel,
149+
protocolLabel
150+
),
151+
{ protocol, address }
152+
);
153+
}
154+
155+
/**
156+
* Bare minimum representation of a port. Supports neither UI labels nor properties.
157+
*/
158+
interface PortDescriptor {
159+
readonly protocol: string;
160+
readonly address: string;
161+
}
162+
function createMonitorError(
163+
code: number
164+
): ApplicationError.Constructor<number, PortDescriptor> {
165+
return ApplicationError.declare(
166+
code,
167+
(message: string, data: PortDescriptor) => ({ data, message })
168+
);
95169
}

‎arduino-ide-extension/src/node/core-service-impl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import {
2323
UploadUsingProgrammerResponse,
2424
} from './cli-protocol/cc/arduino/cli/commands/v1/upload_pb';
2525
import { ResponseService } from '../common/protocol/response-service';
26-
import { OutputMessage, Port, Status } from '../common/protocol';
26+
import { OutputMessage, Port } from '../common/protocol';
2727
import { ArduinoCoreServiceClient } from './cli-protocol/cc/arduino/cli/commands/v1/commands_grpc_pb';
2828
import { Port as RpcPort } from './cli-protocol/cc/arduino/cli/commands/v1/port_pb';
2929
import { ApplicationError, CommandService, Disposable, nls } from '@theia/core';
@@ -392,7 +392,7 @@ export class CoreServiceImpl extends CoreClientAware implements CoreService {
392392
}: {
393393
fqbn?: string | undefined;
394394
port?: Port | undefined;
395-
}): Promise<Status> {
395+
}): Promise<void> {
396396
this.boardDiscovery.setUploadInProgress(false);
397397
return this.monitorManager.notifyUploadFinished(fqbn, port);
398398
}

‎arduino-ide-extension/src/node/monitor-manager-proxy-impl.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { inject, injectable } from '@theia/core/shared/inversify';
22
import {
33
MonitorManagerProxy,
44
MonitorManagerProxyClient,
5-
Status,
65
} from '../common/protocol';
76
import { Board, Port } from '../common/protocol';
87
import { MonitorManager } from './monitor-manager';
@@ -41,11 +40,8 @@ export class MonitorManagerProxyImpl implements MonitorManagerProxy {
4140
await this.changeMonitorSettings(board, port, settings);
4241
}
4342

44-
const connectToClient = (status: Status) => {
45-
if (status === Status.ALREADY_CONNECTED || status === Status.OK) {
46-
// Monitor started correctly, connect it with the frontend
47-
this.client.connect(this.manager.getWebsocketAddressPort(board, port));
48-
}
43+
const connectToClient = () => {
44+
this.client.connect(this.manager.getWebsocketAddressPort(board, port));
4945
};
5046
return this.manager.startMonitor(board, port, connectToClient);
5147
}

‎arduino-ide-extension/src/node/monitor-manager.ts

Lines changed: 20 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import { ILogger } from '@theia/core';
22
import { inject, injectable, named } from '@theia/core/shared/inversify';
3-
import { Board, BoardsService, Port, Status } from '../common/protocol';
3+
import {
4+
AlreadyConnectedError,
5+
Board,
6+
BoardsService,
7+
Port,
8+
} from '../common/protocol';
49
import { CoreClientAware } from './core-client-provider';
510
import { MonitorService } from './monitor-service';
611
import { MonitorServiceFactory } from './monitor-service-factory';
@@ -36,7 +41,7 @@ export class MonitorManager extends CoreClientAware {
3641
private monitorServiceStartQueue: {
3742
monitorID: string;
3843
serviceStartParams: [Board, Port];
39-
connectToClient: (status: Status) => void;
44+
connectToClient: () => void;
4045
}[] = [];
4146

4247
@inject(MonitorServiceFactory)
@@ -104,7 +109,7 @@ export class MonitorManager extends CoreClientAware {
104109
async startMonitor(
105110
board: Board,
106111
port: Port,
107-
connectToClient: (status: Status) => void
112+
connectToClient: () => void
108113
): Promise<void> {
109114
const monitorID = this.monitorID(board.fqbn, port);
110115

@@ -127,8 +132,14 @@ export class MonitorManager extends CoreClientAware {
127132
return;
128133
}
129134

130-
const result = await monitor.start();
131-
connectToClient(result);
135+
try {
136+
await monitor.start();
137+
} catch (err) {
138+
if (!AlreadyConnectedError.is(err)) {
139+
throw err;
140+
}
141+
}
142+
await connectToClient();
132143
}
133144

134145
/**
@@ -202,8 +213,7 @@ export class MonitorManager extends CoreClientAware {
202213
async notifyUploadFinished(
203214
fqbn?: string | undefined,
204215
port?: Port
205-
): Promise<Status> {
206-
let status: Status = Status.NOT_CONNECTED;
216+
): Promise<void> {
207217
let portDidChangeOnUpload = false;
208218

209219
// We have no way of knowing which monitor
@@ -214,7 +224,7 @@ export class MonitorManager extends CoreClientAware {
214224

215225
const monitor = this.monitorServices.get(monitorID);
216226
if (monitor) {
217-
status = await monitor.start();
227+
await monitor.start();
218228
}
219229

220230
// this monitorID will only be present in "disposedForUpload"
@@ -232,7 +242,6 @@ export class MonitorManager extends CoreClientAware {
232242
}
233243

234244
await this.startQueuedServices(portDidChangeOnUpload);
235-
return status;
236245
}
237246

238247
async startQueuedServices(portDidChangeOnUpload: boolean): Promise<void> {
@@ -261,8 +270,8 @@ export class MonitorManager extends CoreClientAware {
261270
const monitorService = this.monitorServices.get(monitorID);
262271

263272
if (monitorService) {
264-
const result = await monitorService.start();
265-
connectToClient(result);
273+
await monitorService.start();
274+
await connectToClient();
266275
}
267276
}
268277
}

‎arduino-ide-extension/src/node/monitor-service.ts

Lines changed: 79 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,22 @@
11
import { ClientDuplexStream } from '@grpc/grpc-js';
2-
import { Disposable, Emitter, ILogger } from '@theia/core';
2+
import {
3+
ApplicationError,
4+
Disposable,
5+
Emitter,
6+
ILogger,
7+
nls,
8+
} from '@theia/core';
39
import { inject, named, postConstruct } from '@theia/core/shared/inversify';
410
import { diff, Operation } from 'just-diff';
5-
import { Board, Port, Status, Monitor } from '../common/protocol';
11+
import {
12+
Board,
13+
Port,
14+
Monitor,
15+
createAlreadyConnectedError,
16+
createMissingConfigurationError,
17+
createNotConnectedError,
18+
createConnectionFailedError,
19+
} from '../common/protocol';
620
import {
721
EnumerateMonitorPortSettingsRequest,
822
EnumerateMonitorPortSettingsResponse,
@@ -19,8 +33,13 @@ import {
1933
PluggableMonitorSettings,
2034
MonitorSettingsProvider,
2135
} from './monitor-settings/monitor-settings-provider';
22-
import { Deferred } from '@theia/core/lib/common/promise-util';
36+
import {
37+
Deferred,
38+
retry,
39+
timeoutReject,
40+
} from '@theia/core/lib/common/promise-util';
2341
import { MonitorServiceFactoryOptions } from './monitor-service-factory';
42+
import { ServiceError } from './service-error';
2443

2544
export const MonitorServiceName = 'monitor-service';
2645
type DuplexHandlerKeys =
@@ -76,7 +95,7 @@ export class MonitorService extends CoreClientAware implements Disposable {
7695
readonly onDispose = this.onDisposeEmitter.event;
7796

7897
private _initialized = new Deferred<void>();
79-
private creating: Deferred<Status>;
98+
private creating: Deferred<void>;
8099
private readonly board: Board;
81100
private readonly port: Port;
82101
private readonly monitorID: string;
@@ -154,25 +173,24 @@ export class MonitorService extends CoreClientAware implements Disposable {
154173

155174
/**
156175
* Start and connects a monitor using currently set board and port.
157-
* If a monitor is already started or board fqbn, port address and/or protocol
158-
* are missing nothing happens.
159-
* @returns a status to verify connection has been established.
176+
* If a monitor is already started, the promise will reject with an `AlreadyConnectedError`.
177+
* If the board fqbn, port address and/or protocol are missing, the promise rejects with a `MissingConfigurationError`.
160178
*/
161-
async start(): Promise<Status> {
179+
async start(): Promise<void> {
162180
if (this.creating?.state === 'unresolved') return this.creating.promise;
163181
this.creating = new Deferred();
164182
if (this.duplex) {
165183
this.updateClientsSettings({
166184
monitorUISettings: { connected: true, serialPort: this.port.address },
167185
});
168-
this.creating.resolve(Status.ALREADY_CONNECTED);
186+
this.creating.reject(createAlreadyConnectedError(this.port));
169187
return this.creating.promise;
170188
}
171189

172190
if (!this.board?.fqbn || !this.port?.address || !this.port?.protocol) {
173191
this.updateClientsSettings({ monitorUISettings: { connected: false } });
174192

175-
this.creating.resolve(Status.CONFIG_MISSING);
193+
this.creating.reject(createMissingConfigurationError(this.port));
176194
return this.creating.promise;
177195
}
178196

@@ -218,10 +236,8 @@ export class MonitorService extends CoreClientAware implements Disposable {
218236
}
219237
monitorRequest.setPortConfiguration(config);
220238

221-
const wroteToStreamSuccessfully = await this.pollWriteToStream(
222-
monitorRequest
223-
);
224-
if (wroteToStreamSuccessfully) {
239+
try {
240+
await this.pollWriteToStream(monitorRequest);
225241
// Only store the config, if the monitor has successfully started.
226242
this.currentPortConfigSnapshot = MonitorPortConfiguration.toObject(
227243
false,
@@ -239,13 +255,20 @@ export class MonitorService extends CoreClientAware implements Disposable {
239255
this.updateClientsSettings({
240256
monitorUISettings: { connected: true, serialPort: this.port.address },
241257
});
242-
this.creating.resolve(Status.OK);
258+
this.creating.resolve();
243259
return this.creating.promise;
244-
} else {
260+
} catch (err) {
245261
this.logger.warn(
246262
`failed starting monitor to ${this.port?.address} using ${this.port?.protocol}`
247263
);
248-
this.creating.resolve(Status.NOT_CONNECTED);
264+
this.creating.reject(
265+
ApplicationError.is(err)
266+
? err
267+
: createConnectionFailedError(
268+
this.port,
269+
err instanceof Error ? err.message : String(err)
270+
)
271+
);
249272
return this.creating.promise;
250273
}
251274
}
@@ -287,21 +310,17 @@ export class MonitorService extends CoreClientAware implements Disposable {
287310
}
288311
}
289312

290-
pollWriteToStream(request: MonitorRequest): Promise<boolean> {
291-
let attemptsRemaining = MAX_WRITE_TO_STREAM_TRIES;
292-
const writeTimeoutMs = WRITE_TO_STREAM_TIMEOUT_MS;
293-
313+
pollWriteToStream(request: MonitorRequest): Promise<void> {
294314
const createWriteToStreamExecutor =
295315
(duplex: ClientDuplexStream<MonitorRequest, MonitorResponse>) =>
296-
(resolve: (value: boolean) => void, reject: () => void) => {
316+
(resolve: () => void, reject: (reason?: unknown) => void) => {
297317
const resolvingDuplexHandlers: DuplexHandler[] = [
298318
{
299319
key: 'error',
300320
callback: async (err: Error) => {
301321
this.logger.error(err);
302-
resolve(false);
303-
// TODO
304-
// this.theiaFEClient?.notifyError()
322+
const details = ServiceError.is(err) ? err.details : err.message;
323+
reject(createConnectionFailedError(this.port, details));
305324
},
306325
},
307326
{
@@ -313,79 +332,47 @@ export class MonitorService extends CoreClientAware implements Disposable {
313332
return;
314333
}
315334
if (monitorResponse.getSuccess()) {
316-
resolve(true);
335+
resolve();
317336
return;
318337
}
319338
const data = monitorResponse.getRxData();
320339
const message =
321340
typeof data === 'string'
322341
? data
323-
: this.streamingTextDecoder.decode(data, {stream:true});
342+
: this.streamingTextDecoder.decode(data, { stream: true });
324343
this.messages.push(...splitLines(message));
325344
},
326345
},
327346
];
328347

329348
this.setDuplexHandlers(duplex, resolvingDuplexHandlers);
330-
331-
setTimeout(() => {
332-
reject();
333-
}, writeTimeoutMs);
334349
duplex.write(request);
335350
};
336351

337-
const pollWriteToStream = new Promise<boolean>((resolve) => {
338-
const startPolling = async () => {
339-
// here we create a new duplex but we don't yet
340-
// set "this.duplex", nor do we use "this.duplex" in our poll
341-
// as duplex 'end' / 'close' events (which we do not "await")
342-
// will set "this.duplex" to null
343-
const createdDuplex = await this.createDuplex();
344-
345-
let pollingIsSuccessful;
346-
// attempt a "writeToStream" and "await" CLI response: success (true) or error (false)
347-
// if we get neither within WRITE_TO_STREAM_TIMEOUT_MS or an error we get undefined
348-
try {
349-
const writeToStream = createWriteToStreamExecutor(createdDuplex);
350-
pollingIsSuccessful = await new Promise(writeToStream);
351-
} catch (error) {
352-
this.logger.error(error);
353-
}
354-
355-
// CLI confirmed port opened successfully
356-
if (pollingIsSuccessful) {
357-
this.duplex = createdDuplex;
358-
resolve(true);
359-
return;
360-
}
361-
362-
// if "pollingIsSuccessful" is false
363-
// the CLI gave us an error, lets try again
364-
// after waiting 2 seconds if we've not already
365-
// reached MAX_WRITE_TO_STREAM_TRIES
366-
if (pollingIsSuccessful === false) {
367-
attemptsRemaining -= 1;
368-
if (attemptsRemaining > 0) {
369-
setTimeout(startPolling, 2000);
370-
return;
371-
} else {
372-
resolve(false);
373-
return;
352+
return Promise.race([
353+
retry(
354+
async () => {
355+
let createdDuplex = undefined;
356+
try {
357+
createdDuplex = await this.createDuplex();
358+
await new Promise<void>(createWriteToStreamExecutor(createdDuplex));
359+
this.duplex = createdDuplex;
360+
} catch (err) {
361+
createdDuplex?.end();
362+
throw err;
374363
}
375-
}
376-
377-
// "pollingIsSuccessful" remains undefined:
378-
// we got no response from the CLI within 30 seconds
379-
// resolve to false and end the duplex connection
380-
resolve(false);
381-
createdDuplex.end();
382-
return;
383-
};
384-
385-
startPolling();
386-
});
387-
388-
return pollWriteToStream;
364+
},
365+
2_000,
366+
MAX_WRITE_TO_STREAM_TRIES
367+
),
368+
timeoutReject(
369+
WRITE_TO_STREAM_TIMEOUT_MS,
370+
nls.localize(
371+
'arduino/monitor/connectionTimeout',
372+
"Timeout. The IDE has not received the 'success' message from the monitor after successfully connecting to it."
373+
)
374+
),
375+
]) as Promise<unknown> as Promise<void>;
389376
}
390377

391378
/**
@@ -429,24 +416,22 @@ export class MonitorService extends CoreClientAware implements Disposable {
429416
* @param message string sent to running monitor
430417
* @returns a status to verify message has been sent.
431418
*/
432-
async send(message: string): Promise<Status> {
419+
async send(message: string): Promise<void> {
433420
if (!this.duplex) {
434-
return Status.NOT_CONNECTED;
421+
throw createNotConnectedError(this.port);
435422
}
436423
const coreClient = await this.coreClient;
437424
const { instance } = coreClient;
438425

439426
const req = new MonitorRequest();
440427
req.setInstance(instance);
441428
req.setTxData(new TextEncoder().encode(message));
442-
return new Promise<Status>((resolve) => {
429+
return new Promise<void>((resolve, reject) => {
443430
if (this.duplex) {
444-
this.duplex?.write(req, () => {
445-
resolve(Status.OK);
446-
});
431+
this.duplex?.write(req, resolve);
447432
return;
448433
}
449-
this.stop().then(() => resolve(Status.NOT_CONNECTED));
434+
this.stop().then(() => reject(createNotConnectedError(this.port)));
450435
});
451436
}
452437

@@ -510,7 +495,7 @@ export class MonitorService extends CoreClientAware implements Disposable {
510495
* @param settings map of monitor settings to change
511496
* @returns a status to verify settings have been sent.
512497
*/
513-
async changeSettings(settings: MonitorSettings): Promise<Status> {
498+
async changeSettings(settings: MonitorSettings): Promise<void> {
514499
const config = new MonitorPortConfiguration();
515500
const { pluggableMonitorSettings } = settings;
516501
const reconciledSettings = await this.monitorSettingsProvider.setSettings(
@@ -537,15 +522,17 @@ export class MonitorService extends CoreClientAware implements Disposable {
537522
});
538523

539524
if (!this.duplex) {
540-
return Status.NOT_CONNECTED;
525+
// instead of throwing an error, return silently like the original logic
526+
// https://github.com/arduino/arduino-ide/blob/9b49712669b06c97bda68a1e5f04eee4664c13f8/arduino-ide-extension/src/node/monitor-service.ts#L540
527+
return;
541528
}
542529

543530
const diffConfig = this.maybeUpdatePortConfigSnapshot(config);
544531
if (!diffConfig) {
545532
this.logger.info(
546533
`No port configuration changes have been detected. No need to send configure commands to the running monitor ${this.port.protocol}:${this.port.address}.`
547534
);
548-
return Status.OK;
535+
return;
549536
}
550537

551538
const coreClient = await this.coreClient;
@@ -560,7 +547,6 @@ export class MonitorService extends CoreClientAware implements Disposable {
560547
req.setInstance(instance);
561548
req.setPortConfiguration(diffConfig);
562549
this.duplex.write(req);
563-
return Status.OK;
564550
}
565551

566552
/**

‎i18n/en.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,11 @@
328328
"tools": "Tools"
329329
},
330330
"monitor": {
331+
"alreadyConnectedError": "Could not connect to {0} {1} port. Already connected.",
332+
"connectionFailedError": "Could not connect to {0} {1} port{2}",
333+
"connectionTimeout": "Timeout. The IDE has not received the 'success' message from the monitor after successfully connecting to it.",
334+
"missingConfigurationError": "Could not connect to {0} {1} port. The monitor configuration is missing.",
335+
"notConnectedError": "Not connected to {0} {1} port.",
331336
"unableToCloseWebSocket": "Unable to close websocket",
332337
"unableToConnectToWebSocket": "Unable to connect to websocket"
333338
},

0 commit comments

Comments
 (0)
Please sign in to comment.