fix: extract push/pull node to their functions

Signed-off-by: Akos Kitta <[email protected]>

Author: Akos Kitta

arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree.ts

@@ -142,29 +142,33 @@ export class CloudSketchbookTree extends SketchbookTree {
       node,
       'pull',
       async (node) => {
-        const commandsCopy = node.commands;
-        node.commands = [];
+        await this.pullNode(node);
+      },
+      noProgress
+    );
+  }
 
-        const localUri = await this.fileService.toUnderlyingResource(
-          LocalCacheUri.root.resolve(node.remoteUri.path)
-        );
-        await this.sync(node.remoteUri, localUri);
+  private async pullNode(node: CloudSketchbookTree.CloudSketchDirNode) {
+    const commandsCopy = node.commands;
+    node.commands = [];
 
-        this.createApi.sketchCache.purgeByPath(node.remoteUri.path.toString());
+    const localUri = await this.fileService.toUnderlyingResource(
+      LocalCacheUri.root.resolve(node.remoteUri.path)
+    );
+    await this.sync(node.remoteUri, localUri);
 
-        node.commands = commandsCopy;
-        this.messageService.info(
-          nls.localize(
-            'arduino/cloud/donePulling',
-            "Done pulling '{0}'.",
-            node.fileStat.name
-          ),
-          {
-            timeout: MESSAGE_TIMEOUT,
-          }
-        );
-      },
-      noProgress
+    this.createApi.sketchCache.purgeByPath(node.remoteUri.path.toString());
+
+    node.commands = commandsCopy;
+    this.messageService.info(
+      nls.localize(
+        'arduino/cloud/donePulling',
+        "Done pulling '{0}'.",
+        node.fileStat.name
+      ),
+      {
+        timeout: MESSAGE_TIMEOUT,
+      }
     );
   }
 
@@ -210,37 +214,41 @@ export class CloudSketchbookTree extends SketchbookTree {
       node,
       'push',
       async (node) => {
-        if (!CloudSketchbookTree.CloudSketchTreeNode.isSynced(node)) {
-          throw new Error(
-            nls.localize(
-              'arduino/cloud/pullFirst',
-              'You have to pull first to be able to push to the Cloud.'
-            )
-          );
-        }
-        const commandsCopy = node.commands;
-        node.commands = [];
+        await this.pushNode(node);
+      },
+      noProgress
+    );
+  }
 
-        const localUri = await this.fileService.toUnderlyingResource(
-          LocalCacheUri.root.resolve(node.remoteUri.path)
-        );
-        await this.sync(localUri, node.remoteUri);
+  private async pushNode(node: CloudSketchbookTree.CloudSketchDirNode) {
+    if (!CloudSketchbookTree.CloudSketchTreeNode.isSynced(node)) {
+      throw new Error(
+        nls.localize(
+          'arduino/cloud/pullFirst',
+          'You have to pull first to be able to push to the Cloud.'
+        )
+      );
+    }
+    const commandsCopy = node.commands;
+    node.commands = [];
 
-        this.createApi.sketchCache.purgeByPath(node.remoteUri.path.toString());
+    const localUri = await this.fileService.toUnderlyingResource(
+      LocalCacheUri.root.resolve(node.remoteUri.path)
+    );
+    await this.sync(localUri, node.remoteUri);
 
-        node.commands = commandsCopy;
-        this.messageService.info(
-          nls.localize(
-            'arduino/cloud/donePushing',
-            "Done pushing '{0}'.",
-            node.fileStat.name
-          ),
-          {
-            timeout: MESSAGE_TIMEOUT,
-          }
-        );
-      },
-      noProgress
+    this.createApi.sketchCache.purgeByPath(node.remoteUri.path.toString());
+
+    node.commands = commandsCopy;
+    this.messageService.info(
+      nls.localize(
+        'arduino/cloud/donePushing',
+        "Done pushing '{0}'.",
+        node.fileStat.name
+      ),
+      {
+        timeout: MESSAGE_TIMEOUT,
+      }
     );
   }