Skip to content

The version is not added correctly #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
umbynos opened this issue Jul 12, 2022 · 1 comment · Fixed by #22
Closed

The version is not added correctly #21

umbynos opened this issue Jul 12, 2022 · 1 comment · Fixed by #22
Assignees
@umbynos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project

Comments

@umbynos
Copy link
Contributor

umbynos commented Jul 12, 2022

Apparently, the ${GITHUB_REF##*/} variable is not expanded correctly in the release CI. This bug has been introduced in #4

./rp2040load -v
rp2040load ${GITHUB_REF##*/} - compiled with go1.16.2
@umbynos umbynos added type: imperfection Perceived defect in any part of project topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Jul 12, 2022
@umbynos umbynos self-assigned this Jul 12, 2022
@per1234
Copy link
Contributor

per1234 commented Jul 12, 2022

I think it is caused by the environment variable having been wrapped in single quotes:

rp2040tools/.github/workflows/release.yml

Line 166 in 8f73b2f

run: go build -ldflags '-X main.version=${GITHUB_REF##*/}'

@umbynos umbynos mentioned this issue Jul 13, 2022
Merged
@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umbynos umbynos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add taskfile and use it in the release pipeline arduino/rp2040tools
2 participants
@per1234 @umbynos