Removed loop, simplified function

Author: cmaglie

go.mod

@@ -5,6 +5,7 @@ go 1.18
 require (
 	github.com/arduino/pluggable-monitor-protocol-handler v0.9.2
 	go.bug.st/serial v1.3.5
+	golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
 )
 
 require (

go.sum

@@ -13,6 +13,8 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
 go.bug.st/serial v1.3.5 h1:k50SqGZCnHZ2MiBQgzccXWG+kd/XpOs1jUljpDDKzaE=
 go.bug.st/serial v1.3.5/go.mod h1:z8CesKorE90Qr/oRSJiEuvzYRKol9r/anJZEb5kt304=
+golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e h1:+WEEuIdZHnUeJJmEUjyYC2gfUMj69yZXw17EnHg/otA=
+golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e/go.mod h1:Kr81I6Kryrl9sr8s2FK3vxD90NdsKWRuOIl2O4CvYbA=
 golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a h1:dGzPydgVsqGcTRVwiLJ1jVbufYwmzD3LfVPLKsKg+0k=
 golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=

main.go

@@ -28,6 +28,7 @@ import (
 	"github.com/arduino/serial-monitor/args"
 	"github.com/arduino/serial-monitor/version"
 	"go.bug.st/serial"
+	"golang.org/x/exp/slices"
 )
 
 func main() {
@@ -103,21 +104,19 @@ func (d *SerialMonitor) Configure(parameterName string, value string) error {
 	if !ok {
 		return fmt.Errorf("could not find parameter named %s", parameterName)
 	}
-	for _, i := range parameter.Values {
-		if i == value {
-			oldValue := parameter.Selected
-			parameter.Selected = value
-			if d.openedPort {
-				err := d.serialPort.SetMode(d.getMode())
-				if err != nil {
-					parameter.Selected = oldValue
-					return errors.New(err.Error())
-				}
-			}
-			return nil
+	if !slices.Contains(parameter.Values, value) {
+		return fmt.Errorf("invalid value for parameter %s: %s", parameterName, value)
+	}
+	oldValue := parameter.Selected
+	parameter.Selected = value
+	if d.openedPort {
+		err := d.serialPort.SetMode(d.getMode())
+		if err != nil {
+			parameter.Selected = oldValue
+			return errors.New(err.Error())
 		}
 	}
-	return fmt.Errorf("invalid value for parameter %s: %s", parameterName, value)
+	return nil
 }
 
 // Open is the handler for the pluggable-monitor OPEN command