optimized isSlice(of other: SyntaxText) -> Bool

art-divin · art-divin · commit 83ad08cb0602 · 2023-10-21T19:02:13.000+04:00
diff --git a/Sources/SwiftSyntax/SyntaxText.swift b/Sources/SwiftSyntax/SyntaxText.swift
@@ -100,7 +100,10 @@ public struct SyntaxText {
     guard !self.isEmpty && !other.isEmpty else {
       return self.isEmpty && other.isEmpty
     }
-    return (other.baseAddress! <= self.baseAddress! && self.baseAddress! + count <= other.baseAddress! + other.count)
+    let first: Bool = other.baseAddress! <= self.baseAddress!
+    let second = UnsafePointer<UInt8>(self.baseAddress! + count)
+    let third = UnsafePointer<UInt8>(other.baseAddress! + other.count)
+    return (first && second <= third)
   }
 
   /// Returns `true` if `other` is a substring of this ``SyntaxText``.

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,10 @@ public struct SyntaxText {`
`100`	`100`	`guard !self.isEmpty && !other.isEmpty else {`
`101`	`101`	`return self.isEmpty && other.isEmpty`
`102`	`102`	`}`
`103`		`- return (other.baseAddress! <= self.baseAddress! && self.baseAddress! + count <= other.baseAddress! + other.count)`
	`103`	`+ let first: Bool = other.baseAddress! <= self.baseAddress!`
	`104`	`+ let second = UnsafePointer<UInt8>(self.baseAddress! + count)`
	`105`	`+ let third = UnsafePointer<UInt8>(other.baseAddress! + other.count)`
	`106`	`+ return (first && second <= third)`
`104`	`107`	`}`
`105`	`108`
`106`	`109`	/// Returns `true` if `other` is a substring of this ``SyntaxText``.