-
Notifications
You must be signed in to change notification settings - Fork 84
Add a Brotli Compression Provider #217
Comments
Might want to use the version in CoreFX Labs for this: https://dotnet.myget.org/feed/dotnet-corefxlab/package/nuget/System.IO.Compression.Brotli |
Yes, this is one of the next things @ianhays will be working on. https://github.com/dotnet/corefx/issues/24826 |
https://github.com/dotnet/corefx/issues/24826 was just finished. We can consume this soon. @muratg we still want to target this for 2.1, correct? |
Out of curiosity, @muratg are you still planning on including brotli support for 2.1 by consuming the CoreFX Brotli library being added in .net core 2.1? FYI: @joshfree |
@ianhays It's not currently in 2.1 list. cc @DamianEdwards |
It would be nice if ASP.NET Core exposed this in 2.1 if there's still time. |
I'd love for us to have this in 2.1, but there are other items ahead of it right now and given where we are it seems unlikely we'll get it in. |
@joshfree I don't think anything changed since @DamianEdwards's comment. He owns the priorities. |
This should be a quick pull request from the community, right? |
Might not be as simple as you think. To do this, #216 also needs to be implemented. |
To make it useful that is... |
Also the fact that System.IO.Compression.Brotli (unless I've missed something) is .NET Core only, might be a challenge (different functionality between platforms). |
Thanks folks for getting this into the 2.2 milestone! |
Uh oh!
There was an error while loading. Please reload this page.
This great post by Tomasz Pęczek shows how to add Brotli compression today using Brotli.NET which is a .NET wrapper around the native Brotli DLL. ASP.NET Core has made a big deal about performance, this should be a higher priority.
Related issue 'Add a Priority to each Response Compression Provider' would also need to be addressed.
The text was updated successfully, but these errors were encountered: