Skip to content
This repository was archived by the owner on Dec 20, 2018. It is now read-only.

Add a Brotli Compression Provider #217

Closed
RehanSaeed opened this issue Mar 21, 2017 · 16 comments
Closed

Add a Brotli Compression Provider #217

RehanSaeed opened this issue Mar 21, 2017 · 16 comments

Comments

@RehanSaeed
Copy link

RehanSaeed commented Mar 21, 2017

This great post by Tomasz Pęczek shows how to add Brotli compression today using Brotli.NET which is a .NET wrapper around the native Brotli DLL. ASP.NET Core has made a big deal about performance, this should be a higher priority.

Related issue 'Add a Priority to each Response Compression Provider' would also need to be addressed.

@muratg muratg added this to the 2.1.0 milestone Jun 12, 2017
@jbayardo
Copy link

jbayardo commented Sep 15, 2017

Might want to use the version in CoreFX Labs for this: https://dotnet.myget.org/feed/dotnet-corefxlab/package/nuget/System.IO.Compression.Brotli

@muratg
Copy link
Contributor

muratg commented Oct 30, 2017

@jkotalik This is not ready yet, but will be once CoreFX packages are in a usable state.

cc @joshfree FYI

@joshfree
Copy link
Member

Yes, this is one of the next things @ianhays will be working on. https://github.com/dotnet/corefx/issues/24826

@jkotalik
Copy link
Contributor

https://github.com/dotnet/corefx/issues/24826 was just finished. We can consume this soon. @muratg we still want to target this for 2.1, correct?

@muratg muratg removed this from the 2.1.0 milestone Jan 20, 2018
@muratg
Copy link
Contributor

muratg commented Jan 20, 2018

@jkotalik possibly, but we'll need to prioritize it with other items.

cc @glennc

@ianhays
Copy link

ianhays commented Feb 26, 2018

Out of curiosity, @muratg are you still planning on including brotli support for 2.1 by consuming the CoreFX Brotli library being added in .net core 2.1?

FYI: @joshfree

@muratg
Copy link
Contributor

muratg commented Feb 26, 2018

@ianhays It's not currently in 2.1 list. cc @DamianEdwards

@joshfree
Copy link
Member

It would be nice if ASP.NET Core exposed this in 2.1 if there's still time.

https://github.com/dotnet/corefx/issues/25785

@DamianEdwards
Copy link
Member

I'd love for us to have this in 2.1, but there are other items ahead of it right now and given where we are it seems unlikely we'll get it in.

@joshfree
Copy link
Member

@muratg @glennc can you prioritize completing this work for .NET Core 2.2?

@muratg
Copy link
Contributor

muratg commented May 18, 2018

@joshfree I don't think anything changed since @DamianEdwards's comment. He owns the priorities.

@khellang
Copy link
Contributor

This should be a quick pull request from the community, right?

@RehanSaeed
Copy link
Author

Might not be as simple as you think. To do this, #216 also needs to be implemented.

@Tratcher
Copy link
Member

To make it useful that is...

@tpeczek
Copy link

tpeczek commented Jun 26, 2018

Also the fact that System.IO.Compression.Brotli (unless I've missed something) is .NET Core only, might be a challenge (different functionality between platforms).

@Tratcher Tratcher added this to the 2.2.0 milestone Jul 10, 2018
@joshfree
Copy link
Member

Thanks folks for getting this into the 2.2 milestone!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants