Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Harden hosting startup #1074

Closed
glennc opened this issue May 16, 2017 · 8 comments
Closed

Harden hosting startup #1074

glennc opened this issue May 16, 2017 · 8 comments
Assignees

Comments

@glennc
Copy link
Member

glennc commented May 16, 2017

  • Aggressively force loading of dependencies in our own implementations of IHostingStartup to avoid delayed load exceptions
  • Ensure VS doesn't attempt to enable hosting startup for AppInsights if application already depends on it explicitly, or that enabling app insights is completely idempotent and we are ok with it being done all the time.
@glennc glennc added this to the 2.0.0-preview2 milestone May 16, 2017
@Tratcher
Copy link
Member

Does this hardening belong in Hosting or in the individual light-up packages? I would think they would be better equipped to understand their own dependencies.

@glennc
Copy link
Member Author

glennc commented May 16, 2017

Each lightup package probably, depends on the plan. Your right this should probably move to AzureIntegration, I blindly put it here because it had hosting in the name.

@Tratcher
Copy link
Member

#1075

@Tratcher
Copy link
Member

Offline notes:

  • Fix Suppress exceptions from failing to load HostingStartup assemblies #1075
  • Lightup packages should touch their primary dependencies from with HostingStartup.
  • Make sure lit up components are idempotent (don’t double register services, middleware, etc..)
  • Many WebHostBuilder methods register callbacks that are executed later, outside of the HostingStartup catch block. If these are the first thing to touch a dependency, they also need to be wrapped. See ConfigureServices, ConfigureLogging, ConfigureAppConfiguration, etc..
  • It's not just 3rd party dependencies that are the problem. An app may deploy and load an earlier version of ASP.NET libraries (e.g. Json config), so when the lightup tries to load the current version it may fail.

Aside from, most of the changes need to be made in the lightup packages. @muratg this need triaging, #1075 is the most critical fix and the only one that will fit in preview2.

@muratg
Copy link

muratg commented May 25, 2017

We did the planned work for preview2. There's a few follow-up items that we'll need to talk about and plan for preview3.

@muratg muratg modified the milestones: 2.0.0-preview3, 2.0.0-preview2 May 25, 2017
@muratg muratg modified the milestones: 2.0.0-preview3, 2.0.0 Jun 12, 2017
@muratg
Copy link

muratg commented Jun 27, 2017

@DamianEdwards do we want to invest time in detectoid work in 2.0.0 RTM?

@DamianEdwards
Copy link
Member

No, I don't think it's critical for release.

@muratg muratg modified the milestones: 2.1.0, 2.0.0 Jun 27, 2017
@muratg
Copy link

muratg commented Aug 8, 2017

Closing as we think what we currently have is good enough.

@muratg muratg closed this as completed Aug 8, 2017
@muratg muratg modified the milestones: 2.1.0, 2.1.0-preview1 Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants