Fix rogue obsoletes

Author: HaoK

src/Microsoft.AspNetCore.Authentication.Core/AuthenticationHandlerProvider.cs

@@ -24,7 +24,7 @@ public async Task<IAuthenticationHandler> GetHandlerAsync(HttpContext context, s
         {
             if (_handlerMap.ContainsKey(authenticationScheme))
             {
-                return _handlerMap[authenticationScheme[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)];
+                return _handlerMap[authenticationScheme];
             }
 
             var scheme = await Schemes.GetSchemeAsync(authenticationScheme);
@@ -38,7 +38,7 @@ public async Task<IAuthenticationHandler> GetHandlerAsync(HttpContext context, s
             if (handler != null)
             {
                 await handler.InitializeAsync(scheme, context);
-                _handlerMap[authenticationScheme[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)] = handler;
+                _handlerMap[authenticationScheme] = handler;
             }
             return handler;
         }

src/Microsoft.AspNetCore.Authentication.Core/AuthenticationSchemeProvider.cs

@@ -77,7 +77,7 @@ public Task<AuthenticationScheme> GetSchemeAsync(string name)
         {
             if (_map.ContainsKey(name))
             {
-                return Task.FromResult(_map[name[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)]);
+                return Task.FromResult(_map[name]);
             }
             return Task.FromResult<AuthenticationScheme>(null);
         }
@@ -103,7 +103,7 @@ public void AddScheme(AuthenticationScheme scheme)
                 {
                     _requestHandlers.Add(scheme);
                 }
-                _map[scheme.Name[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)] = scheme;
+                _map[scheme.Name] = scheme;
             }
         }
 
@@ -117,7 +117,7 @@ public void RemoveScheme(string name)
             {
                 if (_map.ContainsKey(name))
                 {
-                    var scheme = _map[name[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)];
+                    var scheme = _map[name];
                     _requestHandlers.Remove(_requestHandlers.Where(s => s.Name == name).FirstOrDefault());
                     _map.Remove(name);
                 }

src/Microsoft.AspNetCore.Authentication.Core/Properties/Resources.Designer.cs

@@ -20,10 +20,10 @@
     <data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
     <data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
     <data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
-        <value>[base64 mime encoded serialized .NET Framework object[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)]</value>
+        <value>[base64 mime encoded serialized .NET Framework object]</value>
     </data>
     <data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
-        <value>[base64 mime encoded string representing a byte array form of the .NET Framework object[Obsolete("See https://go.microsoft.com/fwlink/?linkid=845470", error: true)]</value>
+        <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
                 

src/Microsoft.AspNetCore.Authentication.Core/Resources.resx

@@ -191,7 +191,9 @@ void TestAllCachedFeaturesAreNull(HttpContext context, IFeatureCollection featur
             TestCachedFeaturesAreNull(context, features);
             TestCachedFeaturesAreNull(context.Request, features);
             TestCachedFeaturesAreNull(context.Response, features);
+#pragma warning disable 618
             TestCachedFeaturesAreNull(context.Authentication, features);
+#pragma warning restore 618
             TestCachedFeaturesAreNull(context.Connection, features);
             TestCachedFeaturesAreNull(context.WebSockets, features);
         }
@@ -220,7 +222,9 @@ void TestAllCachedFeaturesAreSet(HttpContext context, IFeatureCollection feature
             TestCachedFeaturesAreSet(context, features);
             TestCachedFeaturesAreSet(context.Request, features);
             TestCachedFeaturesAreSet(context.Response, features);
+#pragma warning disable 618
             TestCachedFeaturesAreSet(context.Authentication, features);
+#pragma warning restore 618
             TestCachedFeaturesAreSet(context.Connection, features);
             TestCachedFeaturesAreSet(context.WebSockets, features);
         }