Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Minor: Convert single quote strings to double quote ones in the templates #343

Closed
empz opened this issue Sep 30, 2016 · 3 comments
Closed

Comments

@empz
Copy link

empz commented Sep 30, 2016

Following your own Typescript coding standards strings should be double quoted.

Opening a template project with VSCode with TSLint or any other editor with TSLint will underline every string present in the .tsx files as they are all single quoted.

@SteveSandersonMS
Copy link
Member

Pull requests welcome!

@stephtr
Copy link
Contributor

stephtr commented Oct 5, 2016

#360
I hope it is okay to also convert quotes in webpack.config.* files for consistency.

@SteveSandersonMS
Copy link
Member

After further consideration, and with reasons outlined here, we're going to stick with ' in the default templates for now. Obviously you can change it to whatever you want in your own projects!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants