This repository was archived by the owner on Dec 13, 2018. It is now read-only.
File tree Expand file tree Collapse file tree 3 files changed +4
-20
lines changed
src/Microsoft.Extensions.Logging.Filter/Internal
test/Microsoft.Extensions.Logging.Test Expand file tree Collapse file tree 3 files changed +4
-20
lines changed Original file line number Diff line number Diff line change @@ -40,9 +40,9 @@ public void Log<TState>(
40
40
}
41
41
}
42
42
43
- public IDisposable BeginScopeImpl ( object state )
43
+ public IDisposable BeginScope < TState > ( TState state )
44
44
{
45
- return _innerLogger . BeginScopeImpl ( state ) ;
45
+ return _innerLogger . BeginScope ( state ) ;
46
46
}
47
47
48
48
private Func < LogLevel , bool > GetFilter ( )
Original file line number Diff line number Diff line change @@ -14,30 +14,14 @@ namespace Microsoft.Extensions.Logging
14
14
{
15
15
public class EventLogLoggerTest
16
16
{
17
- [ Fact ]
18
- public void CallingBeginScopeOnLogger_AlwaysReturnsNewDisposableInstance ( )
19
- {
20
- // Arrange
21
- var logger = new EventLogLogger ( "Test" ) ;
22
-
23
- // Act
24
- var disposable1 = logger . BeginScopeImpl ( "Scope1" ) ;
25
- var disposable2 = logger . BeginScopeImpl ( "Scope2" ) ;
26
-
27
- // Assert
28
- Assert . NotNull ( disposable1 ) ;
29
- Assert . NotNull ( disposable2 ) ;
30
- Assert . NotSame ( disposable1 , disposable2 ) ;
31
- }
32
-
33
17
[ Fact ]
34
18
public void CallingBeginScopeOnLogger_ReturnsNonNullableInstance ( )
35
19
{
36
20
// Arrange
37
21
var logger = new EventLogLogger ( "Test" ) ;
38
22
39
23
// Act
40
- var disposable = logger . BeginScopeImpl ( "Scope1" ) ;
24
+ var disposable = logger . BeginScope ( "Scope1" ) ;
41
25
42
26
// Assert
43
27
Assert . NotNull ( disposable ) ;
Original file line number Diff line number Diff line change @@ -23,7 +23,7 @@ public static void DiagnosticsScope_PushesAndPops_LogicalOperationStack()
23
23
24
24
// Act
25
25
var a = Trace . CorrelationManager . LogicalOperationStack . Peek ( ) ;
26
- var scope = logger . BeginScopeImpl ( state ) ;
26
+ var scope = logger . BeginScope ( state ) ;
27
27
var b = Trace . CorrelationManager . LogicalOperationStack . Peek ( ) ;
28
28
scope . Dispose ( ) ;
29
29
var c = Trace . CorrelationManager . LogicalOperationStack . Peek ( ) ;
You can’t perform that action at this time.
0 commit comments