Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit d734603

Browse files
lodejardBrennanConroy
authored andcommitted
Additional unit test calls
1 parent 6ab4b11 commit d734603

File tree

3 files changed

+4
-20
lines changed

3 files changed

+4
-20
lines changed

src/Microsoft.Extensions.Logging.Filter/Internal/FilterLogger.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ public void Log<TState>(
4040
}
4141
}
4242

43-
public IDisposable BeginScopeImpl(object state)
43+
public IDisposable BeginScope<TState>(TState state)
4444
{
45-
return _innerLogger.BeginScopeImpl(state);
45+
return _innerLogger.BeginScope(state);
4646
}
4747

4848
private Func<LogLevel, bool> GetFilter()

test/Microsoft.Extensions.Logging.Test/EventLogLoggerTest.cs

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,30 +14,14 @@ namespace Microsoft.Extensions.Logging
1414
{
1515
public class EventLogLoggerTest
1616
{
17-
[Fact]
18-
public void CallingBeginScopeOnLogger_AlwaysReturnsNewDisposableInstance()
19-
{
20-
// Arrange
21-
var logger = new EventLogLogger("Test");
22-
23-
// Act
24-
var disposable1 = logger.BeginScopeImpl("Scope1");
25-
var disposable2 = logger.BeginScopeImpl("Scope2");
26-
27-
// Assert
28-
Assert.NotNull(disposable1);
29-
Assert.NotNull(disposable2);
30-
Assert.NotSame(disposable1, disposable2);
31-
}
32-
3317
[Fact]
3418
public void CallingBeginScopeOnLogger_ReturnsNonNullableInstance()
3519
{
3620
// Arrange
3721
var logger = new EventLogLogger("Test");
3822

3923
// Act
40-
var disposable = logger.BeginScopeImpl("Scope1");
24+
var disposable = logger.BeginScope("Scope1");
4125

4226
// Assert
4327
Assert.NotNull(disposable);

test/Microsoft.Extensions.Logging.Test/TraceSourceScopeTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public static void DiagnosticsScope_PushesAndPops_LogicalOperationStack()
2323

2424
// Act
2525
var a = Trace.CorrelationManager.LogicalOperationStack.Peek();
26-
var scope = logger.BeginScopeImpl(state);
26+
var scope = logger.BeginScope(state);
2727
var b = Trace.CorrelationManager.LogicalOperationStack.Peek();
2828
scope.Dispose();
2929
var c = Trace.CorrelationManager.LogicalOperationStack.Peek();

0 commit comments

Comments
 (0)