Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

[Proposal] LogValues should throw if too many/too few arguments in format string #413

Closed
@BrennanConroy

Description

@BrennanConroy

Its easy to make a mistake when using Define such as LoggerMessage.Define<string>(x:, y:, formatString: "my string"). This will then throw later if the developer enumerates the values, we should try to throw upon construction.

See issues like aspnet/Mvc#4575 (comment)

Activity

self-assigned this
on May 2, 2016
added this to the 1.0.0-rc2 milestone on May 2, 2016
modified the milestones: 1.0.0, 1.0.0-rc2 on May 2, 2016
added 2 commits that reference this issue on May 2, 2016
b175ab2
e751525
added a commit that references this issue on May 2, 2016
c32e76f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @Eilon@kichalla@BrennanConroy

      Issue actions

        [Proposal] LogValues should throw if too many/too few arguments in format string · Issue #413 · aspnet/Logging