-
Notifications
You must be signed in to change notification settings - Fork 109
Add Microsoft.AspNet.Configuration targeting default configuration schema #117
Comments
Does it really have to be that nested? This looks very XMLy 😄 The "Microsoft" and "AspNetCore" containers seem to be unnecessary because they probably won't have properties on their own. Would be nicer if we could just use "Logging", "Authentication", "Hosting" (or maybe even "Kestrel") as top-level entries. People will be smart enough to use different titles for their own areas. It would also make it easier/more readable for flat-item providers - |
After discussing with @davidfowl and @danroth27 updated implementation plan:
|
4b18cf5 has added Templates and Kestrel still need to be updated to use the new config schema shown in dotnet/templating#862 |
@HaoK Hey, just curious, why has this feature been removed a month later after it was introduced? I’ve been jumping around and looking at various issues in other repos but I couldn’t find something that explained the decision to roll back. – Thanks! |
We decided not to introduce any default config binding like this across the board since its already possible to easily bind a config section to an options, something like this is a pattern which works across already:
|
Ah, yeah, I have been wondering about that since this didn’t actually add functionality that wasn’t already available in a slightly different form before. But this being organized on a large-scale and then unshipped a month later made me curious. Thanks for the clarification! :) |
Yeah the feature that was driving all that config coordination was cut, which let us roll this back |
• Create a new Microsoft.AspNetCore.Configuration that will contain all of our default config schema/setup which lives only in the meta package.
• It will provide a single services.ConfigureAspNetDefaults() [naming TBD] which will add all of the default config conventions, none of the existing AddXyz() methods will use IConfiguration (and we should potentially remove any overloads that exist today)
• Implementation detail: a ConfigureAspNet that implements IConfigureOptions for all things we want to configure by default
• For preview 2, this will consist of whatever is being configured in the templates today (Authentication, IdentityService, Kestrel)
• Longer term: Have intellense/schema for the important config settings.
• The structure of the config will be nested: example using today’s indidual Auth template
The text was updated successfully, but these errors were encountered: