Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Resolve which manifest to trim publish output #57

Closed
JunTaoLuo opened this issue Apr 26, 2017 · 6 comments
Closed

Resolve which manifest to trim publish output #57

JunTaoLuo opened this issue Apr 26, 2017 · 6 comments

Comments

@JunTaoLuo
Copy link
Contributor

In #55, we are now trimming by all manifests. This is due to a few limitations:

  1. dotnet sdk publish targets resolves manifest files as a global item group so we need to set the TargetManifestFiles property in a global property group to ensure it is used. The dotnet sdk should be resolving the list of manifest files in the targets which uses them (will file a bug for this).
  2. There is no cross-platform backwards compatible way of determining the os and platform outside of an MSBuild target.

Though in theory, trimming by all manifests should be correct, we may want to be more specific with which manifest to trim by in the future. If we decide to keep this behaviour, we should at least consolidate all manifests into a singular file.

@DamianEdwards
Copy link
Member

This seems to be unblocked now that dotnet/sdk#1164 is complete. Can we do this for preview2?

@DamianEdwards DamianEdwards added this to the 2.0.0-preview2 milestone May 31, 2017
@JunTaoLuo JunTaoLuo self-assigned this Jun 1, 2017
@muratg muratg modified the milestones: 2.0.0-preview3, 2.0.0-preview2 Jun 5, 2017
@JunTaoLuo
Copy link
Contributor Author

The most preferable approach here may be to merge the manifests into one. Will reconsider after preview2 since this isn't critical and only affects the error message when no store is installed.

@muratg
Copy link

muratg commented Jun 27, 2017

@JunTaoLuo do we need to finish this in 2.0.0, or good to move?

@JunTaoLuo
Copy link
Contributor Author

The error message is rather verbose but there is no functional impact. I'll move it out if I can't get to it by next week. We can make the change post 2.0.0 if necessary.

@JunTaoLuo
Copy link
Contributor Author

@muratg suggest we punt this.

@muratg muratg modified the milestones: 2.1.0, 2.0.0 Jun 30, 2017
@JunTaoLuo
Copy link
Contributor Author

In aspnet/Universe#565, we have added consolidation of the manifests. Now there will be one manifest: aspnetcore-store-2.0.3-rtm-71.xml or aspnetcore-store-2.0.3.xml for the no timestamp version.

@muratg muratg modified the milestones: 2.1.0, 2.1.0-preview1 Dec 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants