This repository was archived by the owner on Nov 21, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 109
Resolve which manifest to trim publish output #57
Comments
This seems to be unblocked now that dotnet/sdk#1164 is complete. Can we do this for preview2? |
The most preferable approach here may be to merge the manifests into one. Will reconsider after preview2 since this isn't critical and only affects the error message when no store is installed. |
@JunTaoLuo do we need to finish this in 2.0.0, or good to move? |
The error message is rather verbose but there is no functional impact. I'll move it out if I can't get to it by next week. We can make the change post 2.0.0 if necessary. |
@muratg suggest we punt this. |
In aspnet/Universe#565, we have added consolidation of the manifests. Now there will be one manifest: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In #55, we are now trimming by all manifests. This is due to a few limitations:
TargetManifestFiles
property in a global property group to ensure it is used. The dotnet sdk should be resolving the list of manifest files in the targets which uses them (will file a bug for this).Though in theory, trimming by all manifests should be correct, we may want to be more specific with which manifest to trim by in the future. If we decide to keep this behaviour, we should at least consolidate all manifests into a singular file.
The text was updated successfully, but these errors were encountered: