Addressed feedback

- Renamed TagBindingResult to TagHelperBinding
- Added reference to TagHelperBinding in SetTagHelperPropertyIRNode
- Cleanup

Author: ajaybhargavb

src/Microsoft.AspNetCore.Razor.Evolution/DefaultRazorIRLoweringPhase.cs

@@ -485,9 +485,8 @@ public override void VisitTagHelperBlock(TagHelperChunkGenerator chunkGenerator,
 
                 _builder.Pop(); // Pop InitializeTagHelperStructureIRNode
 
-                var descriptors = tagHelperBlock.BindingResult.Descriptors;
-                AddTagHelperCreation(descriptors);
-                AddTagHelperAttributes(tagHelperBlock.Attributes, descriptors);
+                AddTagHelperCreation(tagHelperBlock.BindingResult);
+                AddTagHelperAttributes(tagHelperBlock.Attributes, tagHelperBlock.BindingResult);
                 AddExecuteTagHelpers();
 
                 _builder.Pop(); // Pop TagHelperIRNode
@@ -508,8 +507,9 @@ private void DeclareTagHelperFields(TagHelperBlock block)
                 }
             }
 
-            private void AddTagHelperCreation(IEnumerable<TagHelperDescriptor> descriptors)
+            private void AddTagHelperCreation(TagHelperBinding tagHelperBinding)
             {
+                var descriptors = tagHelperBinding.Descriptors;
                 foreach (var descriptor in descriptors)
                 {
                     var typeName = descriptor.Metadata[ITagHelperDescriptorBuilder.TypeNameKey];
@@ -523,8 +523,9 @@ private void AddTagHelperCreation(IEnumerable<TagHelperDescriptor> descriptors)
                 }
             }
 
-            private void AddTagHelperAttributes(IList<TagHelperAttributeNode> attributes, IEnumerable<TagHelperDescriptor> descriptors)
+            private void AddTagHelperAttributes(IList<TagHelperAttributeNode> attributes, TagHelperBinding tagHelperBinding)
             {
+                var descriptors = tagHelperBinding.Descriptors;
                 var renderedBoundAttributeNames = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
                 foreach (var attribute in attributes)
                 {
@@ -554,6 +555,7 @@ private void AddTagHelperAttributes(IList<TagHelperAttributeNode> attributes, IE
                                 AttributeName = attribute.Name,
                                 TagHelperTypeName = tagHelperTypeName,
                                 Descriptor = associatedAttributeDescriptor,
+                                TagHelperBinding = tagHelperBinding,
                                 ValueStyle = attribute.ValueStyle,
                                 Source = BuildSourceSpanFromNode(attributeValueNode),
                                 IsIndexerNameMatch = associatedAttributeDescriptor.IsIndexerNameMatch(attribute.Name),

src/Microsoft.AspNetCore.Razor.Evolution/Intermediate/SetPreallocatedTagHelperPropertyIRNode.cs

@@ -2,6 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Collections.Generic;
+using Microsoft.AspNetCore.Razor.Evolution.Legacy;
 
 namespace Microsoft.AspNetCore.Razor.Evolution.Intermediate
 {
@@ -23,6 +24,8 @@ public class SetPreallocatedTagHelperPropertyIRNode : RazorIRNode
 
         public BoundAttributeDescriptor Descriptor { get; set; }
 
+        internal TagHelperBinding TagHelperBinding { get; set; }
+
         public bool IsIndexerNameMatch { get; set; }
 
         public override void Accept(RazorIRNodeVisitor visitor)

src/Microsoft.AspNetCore.Razor.Evolution/Intermediate/SetTagHelperPropertyIRNode.cs

@@ -25,6 +25,8 @@ public class SetTagHelperPropertyIRNode : RazorIRNode
 
         public BoundAttributeDescriptor Descriptor { get; set; }
 
+        internal TagHelperBinding TagHelperBinding { get; set; }
+
         public bool IsIndexerNameMatch { get; set; }
 
         public override void Accept(RazorIRNodeVisitor visitor)

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagBindingResult.cs renamed to src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperBinding.cs

@@ -5,11 +5,11 @@
 
 namespace Microsoft.AspNetCore.Razor.Evolution.Legacy
 {
-    internal sealed class TagBindingResult
+    internal sealed class TagHelperBinding
     {
         public IReadOnlyDictionary<TagHelperDescriptor, IEnumerable<TagMatchingRule>> _applicableDescriptorMappings;
 
-        public TagBindingResult(IReadOnlyDictionary<TagHelperDescriptor, IEnumerable<TagMatchingRule>> applicableDescriptorMappings)
+        public TagHelperBinding(IReadOnlyDictionary<TagHelperDescriptor, IEnumerable<TagMatchingRule>> applicableDescriptorMappings)
         {
             _applicableDescriptorMappings = applicableDescriptorMappings;
             Descriptors = _applicableDescriptorMappings.Keys;

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperBlock.cs

@@ -63,7 +63,7 @@ public TagHelperBlock(TagHelperBlockBuilder source)
         /// <summary>
         /// <see cref="TagHelperDescriptor"/> bindings for the HTML element.
         /// </summary>
-        public TagBindingResult BindingResult { get; }
+        public TagHelperBinding BindingResult { get; }
 
         /// <summary>
         /// The HTML attributes.

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperBlockBuilder.cs

@@ -37,7 +37,7 @@ public TagHelperBlockBuilder(
             TagMode tagMode,
             SourceLocation start,
             IList<TagHelperAttributeNode> attributes,
-            TagBindingResult bindingResult)
+            TagHelperBinding bindingResult)
         {
             TagName = tagName;
             TagMode = tagMode;
@@ -88,7 +88,7 @@ internal TagHelperBlockBuilder(
         /// <summary>
         /// <see cref="TagHelperDescriptor"/>s for the HTML element.
         /// </summary>
-        public TagBindingResult BindingResult { get; }
+        public TagHelperBinding BindingResult { get; }
 
         /// <summary>
         /// The HTML attributes.

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperBlockRewriter.cs

@@ -17,7 +17,7 @@ public static TagHelperBlockBuilder Rewrite(
             string tagName,
             bool validStructure,
             Block tag,
-            TagBindingResult bindingResult,
+            TagHelperBinding bindingResult,
             ErrorSink errorSink)
         {
             // There will always be at least one child for the '<'.
@@ -32,7 +32,7 @@ private static IList<TagHelperAttributeNode> GetTagAttributes(
             string tagName,
             bool validStructure,
             Block tagBlock,
-            TagBindingResult bindingResult,
+            TagHelperBinding bindingResult,
             ErrorSink errorSink)
         {
             var attributes = new List<TagHelperAttributeNode>();
@@ -114,7 +114,7 @@ private static IList<TagHelperAttributeNode> GetTagAttributes(
         private static TagMode GetTagMode(
             string tagName,
             Block beginTagBlock,
-            TagBindingResult bindingResult,
+            TagHelperBinding bindingResult,
             ErrorSink errorSink)
         {
             var childSpan = beginTagBlock.FindLastDescendentSpan();

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperDescriptorProvider.cs

@@ -44,7 +44,7 @@ public TagHelperDescriptorProvider(string tagHelperPrefix, IEnumerable<TagHelper
         /// <returns><see cref="TagHelperDescriptor"/>s that apply to the given <paramref name="tagName"/>.
         /// Will return an empty <see cref="Enumerable" /> if no <see cref="TagHelperDescriptor"/>s are
         /// found.</returns>
-        public TagBindingResult GetTagHelperBinding(
+        public TagHelperBinding GetTagHelperBinding(
             string tagName,
             IEnumerable<KeyValuePair<string, string>> attributes,
             string parentTagName)
@@ -97,7 +97,7 @@ public TagBindingResult GetTagHelperBinding(
                 return null;
             }
 
-            var tagMappingResult = new TagBindingResult(applicableDescriptorMappings);
+            var tagMappingResult = new TagHelperBinding(applicableDescriptorMappings);
 
             return tagMappingResult;
         }

src/Microsoft.AspNetCore.Razor.Evolution/Legacy/TagHelperParseTreeRewriter.cs

@@ -174,7 +174,7 @@ private bool TryRewriteTagHelper(Block tagBlock, ErrorSink errorSink)
                 return false;
             }
 
-            TagBindingResult tagHelperBinding;
+            TagHelperBinding tagHelperBinding;
 
             if (!IsPotentialTagHelper(tagName, tagBlock))
             {
@@ -545,7 +545,7 @@ private static void OnAllowedChildrenTagError(
         }
 
         private static void ValidateBinding(
-            TagBindingResult bindingResult,
+            TagHelperBinding bindingResult,
             string tagName,
             Block tagBlock,
             ErrorSink errorSink)

src/Microsoft.AspNetCore.Razor.Evolution/RazorPreallocatedTagHelperAttributeOptimizationPass.cs

@@ -139,6 +139,7 @@ public override void VisitSetTagHelperProperty(SetTagHelperPropertyIRNode node)
                     TagHelperTypeName = node.TagHelperTypeName,
                     PropertyName = node.PropertyName,
                     Descriptor = node.Descriptor,
+                    TagHelperBinding = node.TagHelperBinding,
                     Parent = node.Parent,
                     IsIndexerNameMatch = node.IsIndexerNameMatch,
                 };