From 974283803730dc27d8f0e69399c4389565f99882 Mon Sep 17 00:00:00 2001 From: InterLinked1 <24227567+InterLinked1@users.noreply.github.com> Date: Sun, 3 Aug 2025 11:55:05 -0400 Subject: [PATCH] dahdi_base.c: Avoid unnecessary strlen call when with strncat. It is not necessary to call strlen on the destination buffer when calling strncat. Resolves: #89 --- drivers/dahdi/dahdi-base.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 87177a69..ae90c512 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5402,14 +5402,12 @@ static int dahdi_ioctl_get_version(unsigned long data) */ continue; } - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ec_name, space); + strncat(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; if (cur->list.next && (cur->list.next != &ecfactory_list)) { - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ", ", space); + strncat(vi.echo_canceller, ", ", space); space -= 2; if (space < 1) break;