Skip to content

Add Support To Trust Customer Cert Authorities #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andscoop opened this issue May 3, 2018 · 3 comments
Closed

Add Support To Trust Customer Cert Authorities #58

andscoop opened this issue May 3, 2018 · 3 comments
Assignees

Comments

@andscoop
Copy link
Contributor

andscoop commented May 3, 2018

Some users will need the ability to trust custom CA's if they choose to supply their own certs which have been issued by a CA not trusted by base OS.

The docker-cli has some code built around this that we should attempt to replicate as closely as possible. This is because of the fact that we are wrapping docker-cli calls in some places as well as making http calls against the registry and houston-api. We will want consistent behavior, especially when we are making an http call and a docker-cli command in the same astro-cli command.

I have some example code proving out the solution, but will need to take time to replicate docker-cli way of doing things.

@andscoop andscoop self-assigned this May 3, 2018
@andscoop
Copy link
Contributor Author

andscoop commented May 3, 2018

Some more context

@andscoop
Copy link
Contributor Author

andscoop commented May 8, 2018

Related issues for future reference. It appears there is a bug in go that may prevent cert reads from the keychain
golang/go#14514
moby/moby#23105

@andscoop
Copy link
Contributor Author

andscoop commented May 8, 2018

One more issue for reference.
golang/go#24652

I think we're going to be good to close this one out with no code changes. It appears that there Is an issue with go reading certs from keychain if the cert is not fully trusted. In the case of enterprise customers using their own cert tools we may run across this again in the future.

To resolve,

1.) Add cert to keychain if it does not exist already
2.) Open keychain go to System Certificates
3.) Find cert and double click to open
4.) Hit "Trust" dropdown arrow
5.) Change "When Using This Certificate" from Use System Defaults to Always Trust
6.) Exit window, you will be prompt for user and pass to save user specific cert settings
7.) Re-attempt deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant