Fix go-gitea#5866: Silence console logger in gitea serv (go-gitea#5887)

zeripath · web-flow · commit 2902b3a68c95 · 2019-02-03T11:19:28.000Z
By default, if `setting.NewContext()` prints out any warning logs, these are printed to the stdout breaking `git receive-pack` etc. meaning that even if there is a warning because of a minor problem in your app.ini but gitea starts despite this - you **CANNOT** push or pull over SSH.

This PR disables the console logger whilst in `serv.go`

Signed-off-by: Andrew Thornton &lt;art27@cantab.net&gt;
diff --git a/cmd/serv.go b/cmd/serv.go
@@ -70,6 +70,7 @@ func checkLFSVersion() {
 }
 
 func setup(logPath string) {
+	log.DelLogger("console")
 	setting.NewContext()
 	checkLFSVersion()
 	log.NewGitLogger(filepath.Join(setting.LogRootPath, logPath))

Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,7 @@ func checkLFSVersion() {`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`func setup(logPath string) {`
	`73`	`+ log.DelLogger("console")`
`73`	`74`	`setting.NewContext()`
`74`	`75`	`checkLFSVersion()`
`75`	`76`	`log.NewGitLogger(filepath.Join(setting.LogRootPath, logPath))`