Skip to content

Put method support #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
8 commits merged into from
Feb 17, 2011
Merged

Put method support #29

8 commits merged into from
Feb 17, 2011

Conversation

bpanulla
Copy link
Contributor

See previous pull request: #26

New goodness, now with unit tests.

@atuttle
Copy link
Owner

atuttle commented Feb 15, 2011

BTW, I did a little research and it looks like when you create a pull request it adds it as a branch to your fork; so if you want to make changes to the pull request, you can push them to that branch, which will automagically add them to the pull request -- no need to close & open separate pull requests. :)

@bpanulla
Copy link
Contributor Author

You're commenting on an interim commit.... the final version addresses this and looks at what comes back in the packet.

Re: branches - yep, I saw that happen with my other pull request. This one was closed for some reason, and reopening wouldn't make it pick them up.

@atuttle
Copy link
Owner

atuttle commented Feb 16, 2011

Ah, ok - missed that. I'll pull it all down at lunch today and run through the tests. At a glance the code looks good, though.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants