Close #582 PR: [breaking] Don't convert non-Error promise rejection reason. Fixes #468

Author: kasperlewau

lib/assert.js

@@ -79,11 +79,7 @@ x.throws = function (fn, err, msg) {
 				x.throws(noop, err, msg);
 			}, function (fnErr) {
 				x.throws(function () {
-					if (fnErr instanceof Error) {
-						throw fnErr;
-					} else {
-						throw new Error(fnErr);
-					}
+					throw fnErr;
 				}, err, msg);
 			});
 	}

readme.md

@@ -562,7 +562,7 @@ Assert that `value` is not deep equal to `expected`.
 
 ### .throws(function|promise, [error, [message]])
 
-Assert that `function` throws an error or `promise` rejects.
+Assert that `function` throws an error, or `promise` rejects with an error.
 
 `error` can be a constructor, regex, error message or validation function.
 

test/promise.js

@@ -210,28 +210,15 @@ test('throws with string argument will reject if message does not match', functi
 	});
 });
 
-test('handle throws with regex with string reject', function (t) {
-	ava(function (a) {
-		a.plan(1);
-
-		var promise = Promise.reject('abc');
-		return a.throws(promise, /abc/);
-	}).run().then(function (result) {
-		t.is(result.passed, true);
-		t.is(result.result.assertCount, 1);
-		t.end();
-	});
-});
-
-test('handle throws with string with string reject', function (t) {
+test('does not handle throws with string reject', function (t) {
 	ava(function (a) {
 		a.plan(1);
 
 		var promise = Promise.reject('abc');
 		return a.throws(promise, 'abc');
 	}).run().then(function (result) {
-		t.is(result.passed, true);
-		t.is(result.result.assertCount, 1);
+		t.is(result.passed, false);
+		t.is(result.reason.name, 'AssertionError');
 		t.end();
 	});
 });