Skip to content

Don't print --fail-fast reminder if no tests were actually skipped #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
novemberborn opened this issue Jan 7, 2017 · 1 comment · Fixed by #1179
Closed

Don't print --fail-fast reminder if no tests were actually skipped #1171

novemberborn opened this issue Jan 7, 2017 · 1 comment · Fixed by #1179
Labels
enhancement new functionality good for beginner help wanted

Comments

@novemberborn
Copy link
Member

With #1160 AVA now prints a reminder when --fail-fast is used and a test fails. Any number of tests could have been skipped.

If all other tests have indeed completed then the reminder is not necessary. A remainingCount could be computed and guarded against when printing the reminder, as described in #1134 (comment).
This was referenced Jan 7, 2017
Closed
Merged
@jarlehansen jarlehansen mentioned this issue Jan 11, 2017
Merged
@novemberborn
Copy link
Member Author

With #1160 AVA now prints a reminder when --fail-fast is used and a test fails. Any number of tests could have been skipped.

Actually, I believe it prints the reminder even if no tests have failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new functionality good for beginner help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only print fail-fast when there are remaining tests jarlehansen/ava
1 participant
@novemberborn