Skip to content

Display internal Node.js stacktrace if no user stacktrace is present #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szmarczak opened this issue Apr 29, 2019 · 6 comments
Closed
Labels
enhancement new functionality 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted scope:assertions

Comments

@szmarczak
Copy link

szmarczak commented Apr 29, 2019

Issuehunt badges

Current behavior

image

Expected behavior

{ Error: self signed certificate
    at TLSSocket.onConnectSecure (_tls_wrap.js:1177:34)
    at TLSSocket.emit (events.js:193:13)
    at TLSSocket._finishInit (_tls_wrap.js:668:8) code: 'DEPTH_ZERO_SELF_SIGNED_CERT' }

IssueHunt Summary

bunysae bunysae has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips

@sindresorhus sindresorhus changed the title Display Node stacktrace if no user stacktrace present Display internal Node.js stacktrace if no user stacktrace is present Apr 30, 2019
@sindresorhus
Copy link
Member

Makes sense to me.

I also notice we don't show the .code property. We should show that if it's not empty, no matter what.

@szmarczak
Copy link
Author

It should also display No user stacktrace present. IMHO

@novemberborn
Copy link
Member

It's a little jarring when there is no stack trace. But, if the Node.js trace lines are useful here, why wouldn't they be useful in other situations?

Should we perhaps color code the trace lines but not filter any?

Agreed we should show all properties of the error.

@sindresorhus
Copy link
Member

It's the difference between the error originating from your own code or from Node.js itself. If it originates from your own code, you don't really care or want the Node.js code frames, but if the error originates from Node.js, you definitely want them for context or being able to report it to the Node.js team.

@novemberborn novemberborn added enhancement new functionality help wanted and removed question labels May 12, 2019
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 2, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 2, 2019

@issuehunt has funded $40.00 to this issue.


@issuehunt-oss
Copy link

issuehunt-oss bot commented Apr 23, 2020

@novemberborn has rewarded $36.00 to @bunysae. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new functionality 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted scope:assertions
Projects
None yet
Development

No branches or pull requests

3 participants