-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Write reporter updates on a fixed interval #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Not sure this will bring any performance benefits for us, because our writes don't happen that often. |
I reckon they would for synchronous tests, but it'd require benchmarking, yes. |
I think it's a good idea regardless, so not to overflow slow terminals (especially a problem with cmd.exe, ofc...). Should be easy to just write to a buffer instead and read from it on an interval. From experience anything between 50-100 ms is good. |
There are test suites out there with many thousands of generated tests that happen very fast. From previous benchmarking, I know the mini reporter is much slower than the verbose one. It is doing way more calculations / writing control characters, etc. |
We should rewrite our reporters using ink. Still, we're OK at the moment. Closing to clean up the backlog. |
From npm v3.10.0 release notes:
This seems like something we could do in AVA.
I imagine this is mostly useful for the mini reporter, which rewrites a single line. That said the verbose reporter still shows a spinner. We could hook the spinner into the drawing scheduler.
The text was updated successfully, but these errors were encountered: