From 194762dfb3258a0735b83e02b5cfd50d1e39ac59 Mon Sep 17 00:00:00 2001
From: Mike Pennisi <mike@mikepennisi.com>
Date: Wed, 13 Sep 2017 19:59:30 -0400
Subject: [PATCH 1/4] Stabilize colors

Prior to this commit, the library and its tests relied on the same code
to add color to terminal output. This prevented the tests from
recognizing changes to that code.

Such a change was introduced in a recent release of the `chalk` module
[1]: it was updated to disable text coloring when run without a TTY.
This is the case in the test environment environment provided by the
`tap` module (which Ava uses for its tests).

This fix disabled color output in the tests, but it caused no failures
because both the expected values and the actual values were effected.
However, this situation amounted to a decrease in test coverage because
the expected color of the terminal output could no longer be verified.

Update the tests environment to simulate a TTY so that Ava continues to
produce colored text despite being run in a sub-process provided by
`tap`. Update the test logic to reduce dependency on Ava internals in
order to avoid similar silent regressions in the future.

[1] https://github.com/chalk/chalk/commit/0827d3b6327dfd5e132589b1308703c9b4e127ef
---
 test/helper/colors.js     |  29 +++++++
 test/reporters/mini.js    | 162 +++++++++++++++++++------------------
 test/reporters/tap.js     |   4 +-
 test/reporters/verbose.js | 164 ++++++++++++++++++++------------------
 4 files changed, 200 insertions(+), 159 deletions(-)
 create mode 100644 test/helper/colors.js

diff --git a/test/helper/colors.js b/test/helper/colors.js
new file mode 100644
index 000000000..7b45cad64
--- /dev/null
+++ b/test/helper/colors.js
@@ -0,0 +1,29 @@
+/**
+ * This module is maintained to promote separation between the tests and the
+ * implementation.
+ */
+'use strict';
+
+const ansiStyles = require('ansi-styles');
+
+function make(name) {
+	const style = ansiStyles[name];
+	return function(string) {
+		return style.open + string + style.close;
+	};
+}
+const bold = make('bold');
+const white = make('white');
+const dim = make('dim');
+const gray = make('gray');
+
+module.exports = {
+	blue: make('blue'),
+	boldWhite: (string) => bold(white(string)),
+	dimGray: (string) => gray(dim(string)),
+	gray: make('gray'),
+	green: make('green'),
+	magenta: make('magenta'),
+	red: make('red'),
+	yellow: make('yellow')
+};
diff --git a/test/reporters/mini.js b/test/reporters/mini.js
index b5f38e42c..080d16644 100644
--- a/test/reporters/mini.js
+++ b/test/reporters/mini.js
@@ -1,9 +1,17 @@
 'use strict';
+
+// These tests are run as a sub-process of the `tap` module, so the standard
+// output stream will not be recognized as a text terminal. Ava internals are
+// sensitive to this detail and respond by automatically disable output
+// coloring. Because the tests are written verify Ava's behavior in text
+// terminals, that environment should be simulated prior to loading any
+// modules.
+process.stdout.isTTY = true;
+
 const indentString = require('indent-string');
 const tempWrite = require('temp-write');
 const flatten = require('arr-flatten');
 const figures = require('figures');
-const chalk = require('chalk');
 const sinon = require('sinon');
 const test = require('tap').test;
 const cross = require('figures').cross;
@@ -11,19 +19,17 @@ const lolex = require('lolex');
 const AvaError = require('../../lib/ava-error');
 const MiniReporter = require('../../lib/reporters/mini');
 const beautifyStack = require('../../lib/beautify-stack');
-const colors = require('../../lib/colors');
+const colors = require('../helper/colors');
 const compareLineOutput = require('../helper/compare-line-output');
 const codeExcerpt = require('../../lib/code-excerpt');
 
-chalk.enabled = true;
-
-const graySpinner = chalk.gray.dim(process.platform === 'win32' ? '-' : '⠋');
+const graySpinner = colors.dimGray(process.platform === 'win32' ? '-' : '⠋');
 const stackLineRegex = /.+ \(.+:[0-9]+:[0-9]+\)/;
 
 // Needed because tap doesn't emulate a tty environment and thus this is
 // `undefined`, making `cli-truncate` append '...' to test titles
 process.stdout.columns = 5000;
-const fullWidthLine = chalk.gray.dim('\u2500'.repeat(5000));
+const fullWidthLine = colors.dimGray('\u2500'.repeat(5000));
 
 function miniReporter(options) {
 	if (options === undefined) {
@@ -64,7 +70,7 @@ test('passing test', t => {
 		' ',
 		' ' + graySpinner + ' passed',
 		'',
-		'  ' + chalk.green('1 passed')
+		'  ' + colors.green('1 passed')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -81,10 +87,10 @@ test('known failure test', t => {
 
 	const expectedOutput = [
 		' ',
-		' ' + graySpinner + ' ' + chalk.red('known failure'),
+		' ' + graySpinner + ' ' + colors.red('known failure'),
 		'',
-		'  ' + chalk.green('1 passed'),
-		'  ' + chalk.red('1 known failure')
+		'  ' + colors.green('1 passed'),
+		'  ' + colors.red('1 known failure')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -103,9 +109,9 @@ test('failing test', t => {
 
 	const expectedOutput = [
 		' ',
-		' ' + graySpinner + ' ' + chalk.red('failed'),
+		' ' + graySpinner + ' ' + colors.red('failed'),
 		'',
-		'  ' + chalk.red('1 failed')
+		'  ' + colors.red('1 failed')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -125,9 +131,9 @@ test('failed known failure test', t => {
 
 	const expectedOutput = [
 		' ',
-		' ' + graySpinner + ' ' + chalk.red('known failure'),
+		' ' + graySpinner + ' ' + colors.red('known failure'),
 		'',
-		'  ' + chalk.red('1 failed')
+		'  ' + colors.red('1 failed')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -150,8 +156,8 @@ test('passing test after failing', t => {
 		' ',
 		' ' + graySpinner + ' passed',
 		'',
-		'  ' + chalk.green('1 passed'),
-		'  ' + chalk.red('1 failed')
+		'  ' + colors.green('1 passed'),
+		'  ' + colors.red('1 failed')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -172,10 +178,10 @@ test('failing test after passing', t => {
 
 	const expectedOutput = [
 		' ',
-		' ' + graySpinner + ' ' + chalk.red('failed'),
+		' ' + graySpinner + ' ' + colors.red('failed'),
 		'',
-		'  ' + chalk.green('1 passed'),
-		'  ' + chalk.red('1 failed')
+		'  ' + colors.green('1 passed'),
+		'  ' + colors.red('1 failed')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -213,7 +219,7 @@ test('results with passing tests', t => {
 	reporter.failCount = 0;
 
 	const actualOutput = reporter.finish({});
-	const expectedOutput = `\n  ${chalk.green('1 passed')}\n`;
+	const expectedOutput = `\n  ${colors.green('1 passed')}\n`;
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -233,10 +239,10 @@ test('results with passing known failure tests', t => {
 	};
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + chalk.green('1 passed'),
-		'\n  ' + chalk.red('1 known failure'),
+		'\n  ' + colors.green('1 passed'),
+		'\n  ' + colors.red('1 known failure'),
 		'\n',
-		'\n   ' + chalk.bold.white('known failure'),
+		'\n   ' + colors.boldWhite('known failure'),
 		'\n'
 	].join('');
 
@@ -251,7 +257,7 @@ test('results with skipped tests', t => {
 	reporter.failCount = 0;
 
 	const actualOutput = reporter.finish({});
-	const expectedOutput = `\n  ${chalk.yellow('1 skipped')}\n`;
+	const expectedOutput = `\n  ${colors.yellow('1 skipped')}\n`;
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -264,7 +270,7 @@ test('results with todo tests', t => {
 	reporter.failCount = 0;
 
 	const actualOutput = reporter.finish({});
-	const expectedOutput = `\n  ${chalk.blue('1 todo')}\n`;
+	const expectedOutput = `\n  ${colors.blue('1 todo')}\n`;
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -278,8 +284,8 @@ test('results with passing skipped tests', t => {
 	const output = reporter.finish({}).split('\n');
 
 	t.is(output[0], '');
-	t.is(output[1], '  ' + chalk.green('1 passed'));
-	t.is(output[2], '  ' + chalk.yellow('1 skipped'));
+	t.is(output[1], '  ' + colors.green('1 passed'));
+	t.is(output[2], '  ' + colors.yellow('1 skipped'));
 	t.is(output[3], '');
 	t.end();
 });
@@ -303,16 +309,16 @@ test('results with passing tests and rejections', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + chalk.green('1 passed'),
-		'  ' + chalk.red('1 rejection'),
+		'  ' + colors.green('1 passed'),
+		'  ' + colors.red('1 rejection'),
 		'',
-		'  ' + chalk.bold.white('Unhandled Rejection'),
+		'  ' + colors.boldWhite('Unhandled Rejection'),
 		/Error: failure/,
 		/test\/reporters\/mini\.js/,
 		compareLineOutput.SKIP_UNTIL_EMPTY_LINE,
 		'',
-		'  ' + chalk.bold.white('Unhandled Rejection'),
-		'  ' + colors.stack('stack line with trailing whitespace'),
+		'  ' + colors.boldWhite('Unhandled Rejection'),
+		'  ' + colors.red('stack line with trailing whitespace'),
 		''
 	]);
 	t.end();
@@ -337,15 +343,15 @@ test('results with passing tests and exceptions', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + chalk.green('1 passed'),
-		'  ' + chalk.red('2 exceptions'),
+		'  ' + colors.green('1 passed'),
+		'  ' + colors.red('2 exceptions'),
 		'',
-		'  ' + chalk.bold.white('Uncaught Exception'),
+		'  ' + colors.boldWhite('Uncaught Exception'),
 		/Error: failure/,
 		/test\/reporters\/mini\.js/,
 		compareLineOutput.SKIP_UNTIL_EMPTY_LINE,
 		'',
-		'  ' + chalk.red(cross + ' A futuristic test runner'),
+		'  ' + colors.red(cross + ' A futuristic test runner'),
 		''
 	]);
 	t.end();
@@ -403,10 +409,10 @@ test('results with errors', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 failed'),
+		'  ' + colors.red('1 failed'),
 		'',
-		'  ' + chalk.bold.white('failed one'),
-		'  ' + chalk.grey(`${err1.source.file}:${err1.source.line}`),
+		'  ' + colors.boldWhite('failed one'),
+		'  ' + colors.gray(`${err1.source.file}:${err1.source.line}`),
 		'',
 		indentString(codeExcerpt(err1.source), 2).split('\n'),
 		'',
@@ -424,8 +430,8 @@ test('results with errors', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('failed two'),
-		'  ' + chalk.grey(`${err2.source.file}:${err2.source.line}`),
+		'  ' + colors.boldWhite('failed two'),
+		'  ' + colors.gray(`${err2.source.file}:${err2.source.line}`),
 		'',
 		indentString(codeExcerpt(err2.source), 2).split('\n'),
 		'',
@@ -441,8 +447,8 @@ test('results with errors', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('failed three'),
-		'  ' + chalk.grey(`${err3.source.file}:${err3.source.line}`),
+		'  ' + colors.boldWhite('failed three'),
+		'  ' + colors.gray(`${err3.source.file}:${err3.source.line}`),
 		'',
 		indentString(codeExcerpt(err3.source), 2).split('\n'),
 		'',
@@ -491,9 +497,9 @@ test('results with errors and disabled code excerpts', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 failed'),
+		'  ' + colors.red('1 failed'),
 		'',
-		'  ' + chalk.bold.white('failed one'),
+		'  ' + colors.boldWhite('failed one'),
 		'',
 		/failure one/,
 		'',
@@ -509,8 +515,8 @@ test('results with errors and disabled code excerpts', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('failed two'),
-		'  ' + chalk.grey(`${err2.source.file}:${err2.source.line}`),
+		'  ' + colors.boldWhite('failed two'),
+		'  ' + colors.gray(`${err2.source.file}:${err2.source.line}`),
 		'',
 		indentString(codeExcerpt(err2.source), 2).split('\n'),
 		'',
@@ -567,10 +573,10 @@ test('results with errors and broken code excerpts', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 failed'),
+		'  ' + colors.red('1 failed'),
 		'',
-		'  ' + chalk.bold.white('failed one'),
-		'  ' + chalk.grey(`${err1.source.file}:${err1.source.line}`),
+		'  ' + colors.boldWhite('failed one'),
+		'  ' + colors.gray(`${err1.source.file}:${err1.source.line}`),
 		'',
 		/failure one/,
 		'',
@@ -586,8 +592,8 @@ test('results with errors and broken code excerpts', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('failed two'),
-		'  ' + chalk.grey(`${err2.source.file}:${err2.source.line}`),
+		'  ' + colors.boldWhite('failed two'),
+		'  ' + colors.gray(`${err2.source.file}:${err2.source.line}`),
 		'',
 		indentString(codeExcerpt(err2.source), 2).split('\n'),
 		'',
@@ -622,9 +628,9 @@ test('results with unhandled errors', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + chalk.red('2 failed'),
+		'  ' + colors.red('2 failed'),
 		'',
-		'  ' + chalk.bold.white('failed one'),
+		'  ' + colors.boldWhite('failed one'),
 		'',
 		/failure one/,
 		'',
@@ -645,7 +651,7 @@ test('results when fail-fast is enabled', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.information('`--fail-fast` is on. At least 1 test was skipped.'),
+		'  ' + colors.magenta('`--fail-fast` is on. At least 1 test was skipped.'),
 		''
 	]);
 	t.end();
@@ -662,7 +668,7 @@ test('results when fail-fast is enabled with multiple skipped tests', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.information('`--fail-fast` is on. At least 2 tests were skipped.'),
+		'  ' + colors.magenta('`--fail-fast` is on. At least 2 tests were skipped.'),
 		''
 	]);
 	t.end();
@@ -705,8 +711,8 @@ test('results with 1 previous failure', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.todo('1 todo'),
-		'  ' + colors.error('1 previous failure in test files that were not rerun'),
+		'  ' + colors.blue('1 todo'),
+		'  ' + colors.red('1 previous failure in test files that were not rerun'),
 		''
 	]);
 	t.end();
@@ -723,8 +729,8 @@ test('results with 2 previous failures', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.todo('1 todo'),
-		'  ' + colors.error('2 previous failures in test files that were not rerun'),
+		'  ' + colors.blue('1 todo'),
+		'  ' + colors.red('2 previous failures in test files that were not rerun'),
 		''
 	]);
 	t.end();
@@ -756,14 +762,14 @@ test('results with watching enabled', t => {
 			'Date'
 		]
 	});
-	const time = ' ' + chalk.grey.dim('[17:19:12]');
+	const time = ' ' + colors.dimGray('[17:19:12]');
 
 	const reporter = miniReporter({color: true, watching: true});
 	reporter.passCount = 1;
 	reporter.failCount = 0;
 
 	const actualOutput = reporter.finish({});
-	const expectedOutput = `\n  ${chalk.green('1 passed') + time}\n`;
+	const expectedOutput = `\n  ${colors.green('1 passed') + time}\n`;
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -798,7 +804,7 @@ test('silently handles errors without body', t => {
 		errors: [{}, {}]
 	};
 	const actualOutput = reporter.finish(runStatus);
-	const expectedOutput = `\n  ${colors.error('1 failed')}\n`;
+	const expectedOutput = `\n  ${colors.red('1 failed')}\n`;
 	t.is(actualOutput, expectedOutput);
 	t.end();
 });
@@ -812,7 +818,7 @@ test('does not handle errors with body in rejections', t => {
 		}]
 	};
 	const actualOutput = reporter.finish(runStatus);
-	const expectedOutput = `\n  ${colors.error('1 rejection')}\n`;
+	const expectedOutput = `\n  ${colors.red('1 rejection')}\n`;
 	t.is(actualOutput, expectedOutput);
 	t.end();
 });
@@ -828,10 +834,10 @@ test('returns description based on error itself if no stack available', t => {
 	};
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + colors.error('1 exception'),
+		'\n  ' + colors.red('1 exception'),
 		'\n',
-		'\n  ' + colors.title('Uncaught Exception'),
-		'\n  ' + colors.stack('Threw non-error: ' + JSON.stringify({error: err1})),
+		'\n  ' + colors.boldWhite('Uncaught Exception'),
+		'\n  ' + colors.red('Threw non-error: ' + JSON.stringify({error: err1})),
 		'\n'
 	].join('');
 	t.is(actualOutput, expectedOutput);
@@ -847,10 +853,10 @@ test('shows "non-error" hint for invalid throws', t => {
 	};
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + colors.error('1 exception'),
+		'\n  ' + colors.red('1 exception'),
 		'\n',
-		'\n  ' + colors.title('Uncaught Exception'),
-		'\n  ' + colors.stack('Threw non-error: function fooFn() {}'),
+		'\n  ' + colors.boldWhite('Uncaught Exception'),
+		'\n  ' + colors.red('Threw non-error: function fooFn() {}'),
 		'\n'
 	].join('');
 	t.is(actualOutput, expectedOutput);
@@ -896,7 +902,7 @@ test('results when hasExclusive is enabled, but there is one remaining tests', t
 
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = '\n' +
-		'  ' + colors.information('The .only() modifier is used in some tests. 1 test was not run') +
+		'  ' + colors.magenta('The .only() modifier is used in some tests. 1 test was not run') +
 		'\n';
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -914,7 +920,7 @@ test('results when hasExclusive is enabled, but there are multiple remaining tes
 
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = '\n' +
-		'  ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run') +
+		'  ' + colors.magenta('The .only() modifier is used in some tests. 2 tests were not run') +
 		'\n';
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -967,14 +973,14 @@ test('results with errors and logs', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 failed'),
+		'  ' + colors.red('1 failed'),
 		'',
-		'  ' + chalk.bold.white('failed one'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log from a failed test'),
-		'      ' + chalk.gray('with a newline'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('another log from failed test'),
+		'  ' + colors.boldWhite('failed one'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log from a failed test'),
+		'      ' + colors.gray('with a newline'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('another log from failed test'),
 		'',
-		'  ' + chalk.grey(`${err1.source.file}:${err1.source.line}`),
+		'  ' + colors.gray(`${err1.source.file}:${err1.source.line}`),
 		'',
 		indentString(codeExcerpt(err1.source), 2).split('\n'),
 		'',
diff --git a/test/reporters/tap.js b/test/reporters/tap.js
index 41ad12d88..6c973dfef 100644
--- a/test/reporters/tap.js
+++ b/test/reporters/tap.js
@@ -2,7 +2,7 @@
 const sinon = require('sinon');
 const test = require('tap').test;
 const hasAnsi = require('has-ansi');
-const chalk = require('chalk');
+const colors = require('../helper/colors');
 const TapReporter = require('../../lib/reporters/tap');
 
 test('start', t => {
@@ -235,7 +235,7 @@ test('reporter strips ANSI characters', t => {
 	const reporter = new TapReporter();
 
 	const output = reporter.test({
-		title: `test ${chalk.gray.dim('›')} my test`,
+		title: `test ${colors.dimGray('›')} my test`,
 		type: 'test',
 		file: 'test.js'
 	});
diff --git a/test/reporters/verbose.js b/test/reporters/verbose.js
index 9c23daea8..76d6b9d3a 100644
--- a/test/reporters/verbose.js
+++ b/test/reporters/verbose.js
@@ -1,20 +1,26 @@
 'use strict';
+
+// These tests are run as a sub-process of the `tap` module, so the standard
+// output stream will not be recognized as a text terminal. Ava internals are
+// sensitive to this detail and respond by automatically disable output
+// coloring. Because the tests are written verify Ava's behavior in text
+// terminals, that environment should be simulated prior to loading any
+// modules.
+process.stdout.isTTY = true;
+
 const indentString = require('indent-string');
 const flatten = require('arr-flatten');
 const tempWrite = require('temp-write');
 const figures = require('figures');
-const chalk = require('chalk');
 const sinon = require('sinon');
 const test = require('tap').test;
 const lolex = require('lolex');
 const beautifyStack = require('../../lib/beautify-stack');
-const colors = require('../../lib/colors');
+const colors = require('../helper/colors');
 const VerboseReporter = require('../../lib/reporters/verbose');
 const compareLineOutput = require('../helper/compare-line-output');
 const codeExcerpt = require('../../lib/code-excerpt');
 
-chalk.enabled = true;
-
 const stackLineRegex = /.+ \(.+:[0-9]+:[0-9]+\)/;
 
 lolex.install({
@@ -23,7 +29,7 @@ lolex.install({
 		'Date'
 	]
 });
-const time = ' ' + chalk.grey.dim('[17:19:12]');
+const time = ' ' + colors.dimGray('[17:19:12]');
 
 function createReporter(options) {
 	if (options === undefined) {
@@ -85,7 +91,7 @@ test('passing test and duration less than threshold', t => {
 		duration: 90
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.green(figures.tick) + ' passed';
+	const expectedOutput = '  ' + colors.green(figures.tick) + ' passed';
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -99,7 +105,7 @@ test('passing test and duration greater than threshold', t => {
 		duration: 150
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.green(figures.tick) + ' passed' + chalk.grey.dim(' (150ms)');
+	const expectedOutput = '  ' + colors.green(figures.tick) + ' passed' + colors.dimGray(' (150ms)');
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -124,7 +130,7 @@ test('known failure test', t => {
 		failing: true
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.red(figures.tick) + ' ' + chalk.red('known failure');
+	const expectedOutput = '  ' + colors.red(figures.tick) + ' ' + colors.red('known failure');
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -140,7 +146,7 @@ test('failing test', t => {
 		}
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.red(figures.cross) + ' failed ' + chalk.red('assertion failed');
+	const expectedOutput = '  ' + colors.red(figures.cross) + ' failed ' + colors.red('assertion failed');
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -154,7 +160,7 @@ test('skipped test', t => {
 		skip: true
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.yellow('- skipped');
+	const expectedOutput = '  ' + colors.yellow('- skipped');
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -169,7 +175,7 @@ test('todo test', t => {
 		todo: true
 	}, createRunStatus());
 
-	const expectedOutput = '  ' + chalk.blue('- todo');
+	const expectedOutput = '  ' + colors.blue('- todo');
 
 	t.is(actualOutput, expectedOutput);
 	t.end();
@@ -186,7 +192,7 @@ test('uncaught exception', t => {
 		stack: beautifyStack(error.stack)
 	}, createRunStatus()).split('\n');
 
-	t.is(output[0], chalk.red('Uncaught Exception: test.js'));
+	t.is(output[0], colors.red('Uncaught Exception: test.js'));
 	t.match(output[1], /Error: Unexpected token/);
 	t.match(output[2], /test\/reporters\/verbose\.js/);
 	t.end();
@@ -202,7 +208,7 @@ test('ava error', t => {
 		message: 'A futuristic test runner'
 	}, createRunStatus()).split('\n');
 
-	t.is(output[0], chalk.red('  ' + figures.cross + ' A futuristic test runner'));
+	t.is(output[0], colors.red('  ' + figures.cross + ' A futuristic test runner'));
 	t.end();
 });
 
@@ -217,7 +223,7 @@ test('unhandled rejection', t => {
 		stack: beautifyStack(error.stack)
 	}, createRunStatus()).split('\n');
 
-	t.is(output[0], chalk.red('Unhandled Rejection: test.js'));
+	t.is(output[0], colors.red('Unhandled Rejection: test.js'));
 	t.match(output[1], /Error: Unexpected token/);
 	t.match(output[2], /test\/reporters\/verbose\.js/);
 	t.end();
@@ -234,8 +240,8 @@ test('unhandled error without stack', t => {
 
 	const output = reporter.unhandledError(err, createRunStatus()).split('\n');
 
-	t.is(output[0], chalk.red('Uncaught Exception: test.js'));
-	t.is(output[1], '  ' + chalk.red(JSON.stringify(err)));
+	t.is(output[0], colors.red('Uncaught Exception: test.js'));
+	t.is(output[1], '  ' + colors.red(JSON.stringify(err)));
 	t.end();
 });
 
@@ -247,7 +253,7 @@ test('results with passing tests', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
+		'  ' + colors.green('1 test passed') + time,
 		''
 	].join('\n');
 
@@ -268,11 +274,11 @@ test('results with passing known failure tests', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.red('1 known failure'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 known failure'),
 		'',
 		'',
-		'  ' + chalk.red('known failure'),
+		'  ' + colors.red('known failure'),
 		''
 	].join('\n');
 
@@ -289,8 +295,8 @@ test('results with skipped tests', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.yellow('1 test skipped'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.yellow('1 test skipped'),
 		''
 	].join('\n');
 
@@ -307,8 +313,8 @@ test('results with todo tests', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.blue('1 test todo'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.blue('1 test todo'),
 		''
 	].join('\n');
 
@@ -325,8 +331,8 @@ test('results with passing tests and rejections', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.red('1 unhandled rejection'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 unhandled rejection'),
 		''
 	].join('\n');
 
@@ -343,8 +349,8 @@ test('results with passing tests and exceptions', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.red('1 uncaught exception'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 uncaught exception'),
 		''
 	].join('\n');
 
@@ -362,9 +368,9 @@ test('results with passing tests, rejections and exceptions', t => {
 	const actualOutput = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
-		'  ' + chalk.red('1 unhandled rejection'),
-		'  ' + chalk.red('1 uncaught exception'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 unhandled rejection'),
+		'  ' + colors.red('1 uncaught exception'),
 		''
 	].join('\n');
 
@@ -422,10 +428,10 @@ test('results with errors', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 test failed') + time,
+		'  ' + colors.red('1 test failed') + time,
 		'',
-		'  ' + chalk.bold.white('fail one'),
-		'  ' + chalk.grey(`${error1.source.file}:${error1.source.line}`),
+		'  ' + colors.boldWhite('fail one'),
+		'  ' + colors.gray(`${error1.source.file}:${error1.source.line}`),
 		'',
 		indentString(codeExcerpt(error1.source), 2).split('\n'),
 		'',
@@ -443,8 +449,8 @@ test('results with errors', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('fail two'),
-		'  ' + chalk.grey(`${error2.source.file}:${error2.source.line}`),
+		'  ' + colors.boldWhite('fail two'),
+		'  ' + colors.gray(`${error2.source.file}:${error2.source.line}`),
 		'',
 		indentString(codeExcerpt(error2.source), 2).split('\n'),
 		'',
@@ -460,8 +466,8 @@ test('results with errors', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('fail three'),
-		'  ' + chalk.grey(`${error3.source.file}:${error3.source.line}`),
+		'  ' + colors.boldWhite('fail three'),
+		'  ' + colors.gray(`${error3.source.file}:${error3.source.line}`),
 		'',
 		indentString(codeExcerpt(error3.source), 2).split('\n'),
 		'',
@@ -508,9 +514,9 @@ test('results with errors and disabled code excerpts', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 test failed') + time,
+		'  ' + colors.red('1 test failed') + time,
 		'',
-		'  ' + chalk.bold.white('fail one'),
+		'  ' + colors.boldWhite('fail one'),
 		'',
 		/error one message/,
 		'',
@@ -526,8 +532,8 @@ test('results with errors and disabled code excerpts', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('fail two'),
-		'  ' + chalk.grey(`${error2.source.file}:${error2.source.line}`),
+		'  ' + colors.boldWhite('fail two'),
+		'  ' + colors.gray(`${error2.source.file}:${error2.source.line}`),
 		'',
 		indentString(codeExcerpt(error2.source), 2).split('\n'),
 		'',
@@ -582,10 +588,10 @@ test('results with errors and disabled code excerpts', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 test failed') + time,
+		'  ' + colors.red('1 test failed') + time,
 		'',
-		'  ' + chalk.bold.white('fail one'),
-		'  ' + chalk.grey(`${error1.source.file}:${error1.source.line}`),
+		'  ' + colors.boldWhite('fail one'),
+		'  ' + colors.gray(`${error1.source.file}:${error1.source.line}`),
 		'',
 		/error one message/,
 		'',
@@ -601,8 +607,8 @@ test('results with errors and disabled code excerpts', t => {
 		'',
 		'',
 		'',
-		'  ' + chalk.bold.white('fail two'),
-		'  ' + chalk.grey(`${error2.source.file}:${error2.source.line}`),
+		'  ' + colors.boldWhite('fail two'),
+		'  ' + colors.gray(`${error2.source.file}:${error2.source.line}`),
 		'',
 		indentString(codeExcerpt(error2.source), 2).split('\n'),
 		'',
@@ -632,9 +638,9 @@ test('results when fail-fast is enabled', t => {
 
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + chalk.red('1 test failed') + time,
+		'\n  ' + colors.red('1 test failed') + time,
 		'\n',
-		'\n  ' + colors.information('`--fail-fast` is on. At least 1 test was skipped.'),
+		'\n  ' + colors.magenta('`--fail-fast` is on. At least 1 test was skipped.'),
 		'\n'
 	].join('');
 
@@ -654,9 +660,9 @@ test('results when fail-fast is enabled with multiple skipped tests', t => {
 
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + chalk.red('1 test failed') + time,
+		'\n  ' + colors.red('1 test failed') + time,
 		'\n',
-		'\n  ' + colors.information('`--fail-fast` is on. At least 2 tests were skipped.'),
+		'\n  ' + colors.magenta('`--fail-fast` is on. At least 2 tests were skipped.'),
 		'\n'
 	].join('');
 
@@ -675,7 +681,7 @@ test('results without fail-fast if no failing tests', t => {
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
+		'  ' + colors.green('1 test passed') + time,
 		''
 	].join('\n');
 
@@ -696,7 +702,7 @@ test('results without fail-fast if no skipped tests', t => {
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.red('1 test failed') + time,
+		'  ' + colors.red('1 test failed') + time,
 		''
 	].join('\n');
 
@@ -715,9 +721,9 @@ test('results with 1 previous failure', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.pass('1 test passed') + time,
-		'  ' + colors.error('1 uncaught exception'),
-		'  ' + colors.error('1 previous failure in test files that were not rerun'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 uncaught exception'),
+		'  ' + colors.red('1 previous failure in test files that were not rerun'),
 		''
 	]);
 	t.end();
@@ -734,9 +740,9 @@ test('results with 2 previous failures', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, [
 		'',
-		'  ' + colors.pass('1 test passed') + time,
-		'  ' + colors.error('1 uncaught exception'),
-		'  ' + colors.error('2 previous failures in test files that were not rerun'),
+		'  ' + colors.green('1 test passed') + time,
+		'  ' + colors.red('1 uncaught exception'),
+		'  ' + colors.red('2 previous failures in test files that were not rerun'),
 		''
 	]);
 	t.end();
@@ -750,7 +756,7 @@ test('full-width line when sectioning', t => {
 	const output = reporter.section();
 	process.stdout.columns = prevColumns;
 
-	t.is(output, chalk.gray.dim('\u2500'.repeat(80)));
+	t.is(output, colors.dimGray('\u2500'.repeat(80)));
 	t.end();
 });
 
@@ -782,7 +788,7 @@ test('results when hasExclusive is enabled, but there are no known remaining tes
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
 		'',
-		'  ' + chalk.green('1 test passed') + time,
+		'  ' + colors.green('1 test passed') + time,
 		''
 	].join('\n');
 
@@ -801,9 +807,9 @@ test('results when hasExclusive is enabled, but there is one remaining tests', t
 
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + chalk.green('1 test passed') + time,
+		'\n  ' + colors.green('1 test passed') + time,
 		'\n',
-		'\n  ' + colors.information('The .only() modifier is used in some tests. 1 test was not run'),
+		'\n  ' + colors.magenta('The .only() modifier is used in some tests. 1 test was not run'),
 		'\n'
 	].join('');
 
@@ -822,9 +828,9 @@ test('results when hasExclusive is enabled, but there are multiple remaining tes
 
 	const output = reporter.finish(runStatus);
 	const expectedOutput = [
-		'\n  ' + chalk.green('1 test passed') + time,
+		'\n  ' + colors.green('1 test passed') + time,
 		'\n',
-		'\n  ' + colors.information('The .only() modifier is used in some tests. 2 tests were not run'),
+		'\n  ' + colors.magenta('The .only() modifier is used in some tests. 2 tests were not run'),
 		'\n'
 	].join('');
 
@@ -862,10 +868,10 @@ test('successful test with logs', t => {
 	}, {});
 
 	const expectedOutput = [
-		'  ' + chalk.green(figures.tick) + ' successful test',
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log message 1'),
-		'      ' + chalk.gray('with a newline'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log message 2')
+		'  ' + colors.green(figures.tick) + ' successful test',
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log message 1'),
+		'      ' + colors.gray('with a newline'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log message 2')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -882,10 +888,10 @@ test('failed test with logs', t => {
 	}, {});
 
 	const expectedOutput = [
-		'  ' + chalk.red(figures.cross) + ' failed test ' + chalk.red('failure'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log message 1'),
-		'      ' + chalk.gray('with a newline'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log message 2')
+		'  ' + colors.red(figures.cross) + ' failed test ' + colors.red('failure'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log message 1'),
+		'      ' + colors.gray('with a newline'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log message 2')
 	].join('\n');
 
 	t.is(actualOutput, expectedOutput);
@@ -916,14 +922,14 @@ test('results with errors and logs', t => {
 	const output = reporter.finish(runStatus);
 	compareLineOutput(t, output, flatten([
 		'',
-		'  ' + chalk.red('1 test failed') + time,
+		'  ' + colors.red('1 test failed') + time,
 		'',
-		'  ' + chalk.bold.white('fail one'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('log from failed test'),
-		'      ' + chalk.gray('with a newline'),
-		'    ' + chalk.magenta(figures.info) + ' ' + chalk.gray('another log from failed test'),
+		'  ' + colors.boldWhite('fail one'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('log from failed test'),
+		'      ' + colors.gray('with a newline'),
+		'    ' + colors.magenta(figures.info) + ' ' + colors.gray('another log from failed test'),
 		'',
-		'  ' + chalk.grey(`${error1.source.file}:${error1.source.line}`),
+		'  ' + colors.gray(`${error1.source.file}:${error1.source.line}`),
 		'',
 		indentString(codeExcerpt(error1.source), 2).split('\n'),
 		'',

From 3b3374c17ab40d3893d4c7f410c753fe69558494 Mon Sep 17 00:00:00 2001
From: Mike Pennisi <mike@mikepennisi.com>
Date: Sun, 17 Sep 2017 16:10:45 -0400
Subject: [PATCH 2/4] fixup! Stabilize colors

---
 test/helper/colors.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/helper/colors.js b/test/helper/colors.js
index 7b45cad64..e7ab7f142 100644
--- a/test/helper/colors.js
+++ b/test/helper/colors.js
@@ -8,7 +8,7 @@ const ansiStyles = require('ansi-styles');
 
 function make(name) {
 	const style = ansiStyles[name];
-	return function(string) {
+	return function (string) {
 		return style.open + string + style.close;
 	};
 }
@@ -19,8 +19,8 @@ const gray = make('gray');
 
 module.exports = {
 	blue: make('blue'),
-	boldWhite: (string) => bold(white(string)),
-	dimGray: (string) => gray(dim(string)),
+	boldWhite: string => bold(white(string)),
+	dimGray: string => gray(dim(string)),
 	gray: make('gray'),
 	green: make('green'),
 	magenta: make('magenta'),

From 3e68bd60c7951ad1e8198971686f7bd3ba58a5a7 Mon Sep 17 00:00:00 2001
From: Mike Pennisi <mike@mikepennisi.com>
Date: Mon, 18 Sep 2017 14:29:37 -0400
Subject: [PATCH 3/4] fixup! Stabilize colors

---
 test/helper/colors.js | 19 +++++++++++++++----
 1 file changed, 15 insertions(+), 4 deletions(-)

diff --git a/test/helper/colors.js b/test/helper/colors.js
index e7ab7f142..bce6ddb28 100644
--- a/test/helper/colors.js
+++ b/test/helper/colors.js
@@ -14,14 +14,25 @@ function make(name) {
 }
 const bold = make('bold');
 const white = make('white');
-const dim = make('dim');
 const gray = make('gray');
 
+// The following color definitions are contextual so that they produce expected
+// values which mimic the behavior of the Chalk library.
+const isSimpleWindowsTerm = process.platform === 'win32' && !(process.env.TERM || '').toLowerCase().startsWith('xterm');
+const openDim = isSimpleWindowsTerm ? '' : ansiStyles.dim.open;
+const openBlue = isSimpleWindowsTerm ? '\u001B[94m' : ansiStyles.blue.open;
+// "Use `bold` by default on Windows"
+// https://github.com/chalk/chalk/issues/36
+const blue = string => openBlue + string + ansiStyles.blue.close;
+// "(Windows) chalk.gray.dim not visible"
+// https://github.com/chalk/chalk/issues/58
+const dimGray = string => gray(openDim + string + ansiStyles.dim.close);
+
 module.exports = {
-	blue: make('blue'),
+	blue,
 	boldWhite: string => bold(white(string)),
-	dimGray: string => gray(dim(string)),
-	gray: make('gray'),
+	dimGray,
+	gray,
 	green: make('green'),
 	magenta: make('magenta'),
 	red: make('red'),

From a1a844d8b2b8606df74e676dd73b656e6780b969 Mon Sep 17 00:00:00 2001
From: Mark Wubben <mark@novemberborn.net>
Date: Sun, 24 Sep 2017 18:00:07 +0100
Subject: [PATCH 4/4] Fix spelling of AVA

---
 test/reporters/mini.js    | 4 ++--
 test/reporters/verbose.js | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/reporters/mini.js b/test/reporters/mini.js
index 080d16644..4daac4c01 100644
--- a/test/reporters/mini.js
+++ b/test/reporters/mini.js
@@ -1,9 +1,9 @@
 'use strict';
 
 // These tests are run as a sub-process of the `tap` module, so the standard
-// output stream will not be recognized as a text terminal. Ava internals are
+// output stream will not be recognized as a text terminal. AVA internals are
 // sensitive to this detail and respond by automatically disable output
-// coloring. Because the tests are written verify Ava's behavior in text
+// coloring. Because the tests are written verify AVA's behavior in text
 // terminals, that environment should be simulated prior to loading any
 // modules.
 process.stdout.isTTY = true;
diff --git a/test/reporters/verbose.js b/test/reporters/verbose.js
index 76d6b9d3a..228bab288 100644
--- a/test/reporters/verbose.js
+++ b/test/reporters/verbose.js
@@ -1,9 +1,9 @@
 'use strict';
 
 // These tests are run as a sub-process of the `tap` module, so the standard
-// output stream will not be recognized as a text terminal. Ava internals are
+// output stream will not be recognized as a text terminal. AVA internals are
 // sensitive to this detail and respond by automatically disable output
-// coloring. Because the tests are written verify Ava's behavior in text
+// coloring. Because the tests are written verify AVA's behavior in text
 // terminals, that environment should be simulated prior to loading any
 // modules.
 process.stdout.isTTY = true;