From 67bfa37d9568e7b15f507d45e4fe329917410e61 Mon Sep 17 00:00:00 2001 From: Abdallah Shaban Date: Mon, 14 Nov 2022 15:01:43 -0500 Subject: [PATCH 1/5] updated findings from Nika --- src/fragments/cli-install-block.mdx | 2 +- .../flutter/create-application/30_provisionBackend.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fragments/cli-install-block.mdx b/src/fragments/cli-install-block.mdx index 4cc0404b78f..01ff4aceca3 100644 --- a/src/fragments/cli-install-block.mdx +++ b/src/fragments/cli-install-block.mdx @@ -11,7 +11,7 @@ npm install -g @aws-amplify/cli ```bash -curl -sL https://aws-amplify.github.io/amplify-cli/install | bash && $SHELL +sudo npm install -g @aws-amplify/cli --unsafe-perm=true ``` diff --git a/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx b/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx index c425d63021e..e7edd50b5bb 100644 --- a/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx +++ b/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx @@ -44,8 +44,8 @@ After the project information is filled, you will be prompted to select the AWS Please choose the profile you want to use (Use arrow keys) > default ``` -> Where possible the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case it knew you are using Create React App and provided the proper configuration for type of app, framework, source, distribution, build, and start options. +> Where possible the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case it knew you are using a Flutter app, source, distribution, build, and start options. Upon successfully running `amplify init`, you will see a configuration file created in `./lib/` called `amplifyconfiguration.dart`. From 98dd013d5bea5500ae516fe767f837bb6f7d3e81 Mon Sep 17 00:00:00 2001 From: Abdallah Shaban Date: Mon, 14 Nov 2022 12:38:24 -0800 Subject: [PATCH 2/5] Update src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx Co-authored-by: Bannon Tanner --- .../flutter/create-application/30_provisionBackend.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx b/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx index e7edd50b5bb..21ed7ca19f8 100644 --- a/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx +++ b/src/fragments/lib/project-setup/flutter/create-application/30_provisionBackend.mdx @@ -45,7 +45,7 @@ Please choose the profile you want to use (Use arrow keys) > default ``` -> Where possible the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case it knew you are using a Flutter app, source, distribution, build, and start options. +> Where possible, the CLI will infer the proper configuration based on the type of project Amplify is being initialized in. In this case, it knew you are using a Flutter app, source, distribution, build, and start options. Upon successfully running `amplify init`, you will see a configuration file created in `./lib/` called `amplifyconfiguration.dart`. From bc5def663915c14ae1f746d36eeaa8ae4752beae Mon Sep 17 00:00:00 2001 From: Abdallah Shaban Date: Mon, 14 Nov 2022 16:18:08 -0500 Subject: [PATCH 3/5] updated Typo --- src/fragments/lib-v1/storage/js/upload.mdx | 2 +- src/fragments/lib/storage/js/browser-uploads.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/fragments/lib-v1/storage/js/upload.mdx b/src/fragments/lib-v1/storage/js/upload.mdx index f087f51a297..95c76314863 100644 --- a/src/fragments/lib-v1/storage/js/upload.mdx +++ b/src/fragments/lib-v1/storage/js/upload.mdx @@ -147,7 +147,7 @@ async function onChange(e) { -Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be emitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'. +Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be omitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'. For example: uploading a file with the key "example.jpg" will result in the 'Type' being set as "jpg", but the 'contentType' in metadata will determine it's behavior so setting it as "text/html" will result in the file being treated as an HTML file regardless of displayed 'Type' in the S3 console. diff --git a/src/fragments/lib/storage/js/browser-uploads.mdx b/src/fragments/lib/storage/js/browser-uploads.mdx index 0db107cd016..a86438fffc5 100644 --- a/src/fragments/lib/storage/js/browser-uploads.mdx +++ b/src/fragments/lib/storage/js/browser-uploads.mdx @@ -19,7 +19,7 @@ async function onChange(e) { -Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be emitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'. +Note: 'contentType' is metadata (saved under the key 'Content-Type') for the S3 object and does not determine the 'Type' in the AWS S3 Console. If a file extension is not provided in the key of the uploaded object, the S3 console's 'Type' field will be omitted. Otherwise, the 'Type' will be populated to match the given extension of the key. The behavior of how the S3 object is treated will be based on 'contentType' in the metadata and not the 'Type'. For example: uploading a file with the key "example.jpg" will result in the 'Type' being set as "jpg", but the 'contentType' in metadata will determine it's behavior so setting it as "text/html" will result in the file being treated as an HTML file regardless of displayed 'Type' in the S3 console. From 8e9f5cc5abf6c10e94fd4ab61a2f3639c19879ac Mon Sep 17 00:00:00 2001 From: Abdallah Shaban Date: Mon, 14 Nov 2022 16:19:40 -0500 Subject: [PATCH 4/5] updated cspell --- cspell.json | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/cspell.json b/cspell.json index 43335ae06d2..cf72f9019d2 100644 --- a/cspell.json +++ b/cspell.json @@ -920,6 +920,7 @@ "oauth", "OAuth", "OAuth2.0", + "omitted", "oauth2", "OBJC", "OBJECT_KEY", @@ -1484,10 +1485,5 @@ "Libre's", "Pinia" ], - "flagWords": [ - "hte", - "full-stack", - "Full-stack", - "Full-Stack" - ] + "flagWords": ["hte", "full-stack", "Full-stack", "Full-Stack"] } From 8ed1ce759526a30d2ca84a4bff230fe5f6bac639 Mon Sep 17 00:00:00 2001 From: Abdallah Shaban Date: Mon, 14 Nov 2022 16:32:26 -0500 Subject: [PATCH 5/5] removed unnecessary cspell --- cspell.json | 1 - 1 file changed, 1 deletion(-) diff --git a/cspell.json b/cspell.json index cf72f9019d2..986aecd5264 100644 --- a/cspell.json +++ b/cspell.json @@ -920,7 +920,6 @@ "oauth", "OAuth", "OAuth2.0", - "omitted", "oauth2", "OBJC", "OBJECT_KEY",