chore(idempotency): simplified strings

rubenfonseca · rubenfonseca · commit 0e9dfd4ef523 · 2022-07-29T15:11:42.000+02:00
diff --git a/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py b/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py
@@ -192,10 +192,9 @@ def _put_record(self, data_record: DataRecord) -> None:
                     "#in_progress_expiry < :now_in_millis",
                 ]
             )
-            inprogress_expiry_expired = f"({inprogress_expiry_expired})"
 
-            condition_expression = " OR ".join(
-                [idempotency_key_not_exist, idempotency_expiry_expired, inprogress_expiry_expired]
+            condition_expression = (
+                f"{idempotency_key_not_exist} OR {idempotency_expiry_expired} OR ({inprogress_expiry_expired})"
             )
 
             self.table.put_item(

Original file line number	Diff line number	Diff line change
`@@ -192,10 +192,9 @@ def _put_record(self, data_record: DataRecord) -> None:`
`192`	`192`	`"#in_progress_expiry < :now_in_millis",`
`193`	`193`	`]`
`194`	`194`	`)`
`195`		`- inprogress_expiry_expired = f"({inprogress_expiry_expired})"`
`196`	`195`
`197`		`- condition_expression = " OR ".join(`
`198`		`- [idempotency_key_not_exist, idempotency_expiry_expired, inprogress_expiry_expired]`
	`196`	`+ condition_expression = (`
	`197`	`+ f"{idempotency_key_not_exist} OR {idempotency_expiry_expired} OR ({inprogress_expiry_expired})"`
`199`	`198`	`)`
`200`	`199`
`201`	`200`	`self.table.put_item(`