Skip to content

Commit b77dab7

Browse files
committed
fix: metric dimension in root blob
1 parent 55ce3a1 commit b77dab7

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

python/aws_lambda_powertools/metrics/base.py

+1
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,7 @@ def serialize_metric_set(self, metrics: Dict = None, dimensions: Dict = None) ->
177177
}
178178
metrics_timestamp = {"Timestamp": int(datetime.datetime.now().timestamp() * 1000)}
179179
metric_set["_aws"] = {**metrics_timestamp, **metrics_definition}
180+
metric_set.update(**dimensions)
180181

181182
try:
182183
logger.debug("Validating serialized metrics against CloudWatch EMF schema", metric_set)

python/tests/functional/test_metrics.py

+2
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,8 @@ def lambda_handler(evt, handler):
155155

156156
remove_timestamp(metrics=[output, expected]) # Timestamp will always be different
157157
assert expected["_aws"] == output["_aws"]
158+
for dimension in dimensions:
159+
assert dimension['name'] in output
158160

159161

160162
def test_namespace_env_var(monkeypatch, capsys, metric, dimension, namespace):

0 commit comments

Comments
 (0)