Skip to content

Bug: Build fails if poetry-core>=1.1.0a6 is not specified #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BastianZim opened this issue Oct 24, 2022 · 7 comments · Fixed by #1651
Closed

Bug: Build fails if poetry-core>=1.1.0a6 is not specified #1646

BastianZim opened this issue Oct 24, 2022 · 7 comments · Fixed by #1651
Labels
bug Something isn't working

Comments

@BastianZim
Copy link
Contributor

BastianZim commented Oct 24, 2022

Expected Behaviour

Build succeeds

Current Behaviour

Build fails.

Logs: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=594749&view=logs&jobId=656edd35-690f-5c53-9ba3-09c10d0bea97&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d

Code snippet

python -m pip install . -vv

Possible Solution

As described in python-poetry/poetry#4983 it can be fixed by adding poetry-core>=1.1.0a6 to the build requirements.

Additionally, it might make sense to switch to poetry-core: https://github.com/python-poetry/poetry-core

Steps to Reproduce

Build package
PR: conda-forge/aws-lambda-powertools-feedstock#53

AWS Lambda Powertools for Python version

latest

Packaging format used

PyPi

Debugging logs

Processing $SRC_DIR
  Added file://$SRC_DIR to build tracker '/tmp/pip-build-tracker-vc54bee8'
  Created temporary directory: /tmp/pip-modern-metadata-o32viuml
  Preparing metadata (pyproject.toml): started
  Running command Preparing metadata (pyproject.toml)
  Traceback (most recent call last):
    File "/home/conda/feedstock_root/build_artifacts/aws-lambda-powertools_1666621594121/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 351, in <module>
      main()
    File "/home/conda/feedstock_root/build_artifacts/aws-lambda-powertools_1666621594121/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 333, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
    File "/home/conda/feedstock_root/build_artifacts/aws-lambda-powertools_1666621594121/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 152, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
    File "/home/conda/feedstock_root/build_artifacts/aws-lambda-powertools_1666621594121/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/poetry/core/masonry/api.py", line 43, in prepare_metadata_for_build_wheel
      poetry = Factory().create_poetry(Path(".").resolve(), with_dev=False)
    File "/home/conda/feedstock_root/build_artifacts/aws-lambda-powertools_1666621594121/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.10/site-packages/poetry/core/factory.py", line 43, in create_poetry
      raise RuntimeError("The Poetry configuration is invalid:\n" + message)
  RuntimeError: The Poetry configuration is invalid:
    - Additional properties are not allowed ('group' was unexpected)
@BastianZim BastianZim added bug Something isn't working triage Pending triage from maintainers labels Oct 24, 2022
@heitorlessa
Copy link
Contributor

Hey @BastianZim good see you around again - let us investigate tomorrow and come back to you.

I wonder whether having poetry installed might have contributed to not hitting this in E2E and release pipeline, since pip install against PyPi already has the artefact built and isolated VS dev install.

@BastianZim
Copy link
Contributor Author

Hey @heitorlessa long time no talk 😄

Hmm, yes, that could be. To be honest, this is probably something that should be restricted upstream in the long run but I just wanted to mention it here as short-term fixes are probably faster implemented here.

@rubenfonseca rubenfonseca removed the triage Pending triage from maintainers label Oct 25, 2022
@rubenfonseca rubenfonseca linked a pull request Oct 25, 2022 that will close this issue
7 tasks
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Oct 25, 2022
@github-actions
Copy link
Contributor

This is now released under 2.1.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Oct 31, 2022
@heitorlessa
Copy link
Contributor

@BastianZim - let us know if this didn't fix it for some reason! and thank you again!

@BastianZim
Copy link
Contributor Author

@heitorlessa It worked like a charm, thank you! :)

@heitorlessa
Copy link
Contributor

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants