Skip to content

Tech debt: Improve Metrics provider to make it more maintainable #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 of 7 tasks
leandrodamascena opened this issue Aug 2, 2023 · 3 comments · Fixed by #2934
Closed
4 of 7 tasks

Tech debt: Improve Metrics provider to make it more maintainable #2916

leandrodamascena opened this issue Aug 2, 2023 · 3 comments · Fixed by #2934
Assignees
@leandrodamascena
Labels
tech-debt Technical Debt tasks

Comments

@leandrodamascena
Copy link
Contributor

leandrodamascena commented Aug 2, 2023 •
edited
Loading

Why is this needed?

In the PR #2194 we refactored the Metrics utility to allow bring new utilities. But it created some technical debt that must be addressed now.

Some items we need to fix:

  • Cleanup the slight confusion in OOO / Protocol
  • Fix possible mistakes in docstrings
  • Remove old and commented code
  • Refactor extract* into standalone functions to reduce call graph
  • Split up functional and unit tests with new providers

Which area does this relate to?

Metrics

Suggestion

No response

Acknowledgment
@leandrodamascena leandrodamascena added triage Pending triage from maintainers tech-debt Technical Debt tasks labels Aug 2, 2023
@leandrodamascena leandrodamascena mentioned this issue Aug 2, 2023
Closed
2 tasks
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Aug 3, 2023
@heitorlessa heitorlessa moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Aug 3, 2023
@heitorlessa
Copy link
Contributor

adjusting labels to prevent incorrect metrics

@heitorlessa heitorlessa changed the title Tech debt: Fix the metrics utility to make the code clean and uniform. Tech debt: Improve Metrics provider to make it more maintainable Aug 3, 2023
@leandrodamascena leandrodamascena mentioned this issue Aug 7, 2023
Merged
7 tasks
@leandrodamascena leandrodamascena linked a pull request Aug 7, 2023 that will close this issue
refactor(metrics): move from protocol to ABC; split provider tests #2934
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Aug 9, 2023
@github-actions
Copy link
Contributor

This is now released under 2.23.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Aug 18, 2023
@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandrodamascena leandrodamascena

Labels
tech-debt Technical Debt tasks
Projects
Powertools for AWS Lambda (Python)
Status: Shipped
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(metrics): move from protocol to ABC; split provider tests
2 participants
@heitorlessa @leandrodamascena