From 4448b80f1d8e1aba83d6de5b228435f03f395260 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 28 Apr 2022 13:42:13 +0000 Subject: [PATCH 1/2] chore(deps-dev): bump flake8-bugbear from 22.1.11 to 22.4.25 Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 22.1.11 to 22.4.25. - [Release notes](https://github.com/PyCQA/flake8-bugbear/releases) - [Commits](https://github.com/PyCQA/flake8-bugbear/compare/22.1.11...22.4.25) --- updated-dependencies: - dependency-name: flake8-bugbear dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- poetry.lock | 8 ++++---- pyproject.toml | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/poetry.lock b/poetry.lock index 154d4756c94..10c411af490 100644 --- a/poetry.lock +++ b/poetry.lock @@ -243,7 +243,7 @@ toml = "*" [[package]] name = "flake8-bugbear" -version = "22.1.11" +version = "22.4.25" description = "A plugin for flake8 finding likely bugs and design problems in your program. Contains warnings that don't belong in pyflakes and pycodestyle." category = "dev" optional = false @@ -1057,7 +1057,7 @@ pydantic = ["pydantic", "email-validator"] [metadata] lock-version = "1.1" python-versions = "^3.6.2" -content-hash = "1eb1fbcadee353bf7a33849c7b0c5be67117feec4096a5115cae7c43fe288d85" +content-hash = "cf8b7764b84b398aeca74c548ad9872294a4f772ea1b1a93899ac6d70b2ef2b6" [metadata.files] atomicwrites = [ @@ -1181,8 +1181,8 @@ flake8-black = [ {file = "flake8_black-0.2.3-py3-none-any.whl", hash = "sha256:cc080ba5b3773b69ba102b6617a00cc4ecbad8914109690cfda4d565ea435d96"}, ] flake8-bugbear = [ - {file = "flake8-bugbear-22.1.11.tar.gz", hash = "sha256:4c2a4136bd4ecb8bf02d5159af302ffc067642784c9d0488b33ce4610da825ee"}, - {file = "flake8_bugbear-22.1.11-py3-none-any.whl", hash = "sha256:ce7ae44aaaf67ef192b8a6de94a5ac617144e1675ad0654fdea556f48dc18d9b"}, + {file = "flake8-bugbear-22.4.25.tar.gz", hash = "sha256:f7c080563fca75ee6b205d06b181ecba22b802babb96b0b084cc7743d6908a55"}, + {file = "flake8_bugbear-22.4.25-py3-none-any.whl", hash = "sha256:ec374101cddf65bd7a96d393847d74e58d3b98669dbf9768344c39b6290e8bd6"}, ] flake8-builtins = [ {file = "flake8-builtins-1.5.3.tar.gz", hash = "sha256:09998853b2405e98e61d2ff3027c47033adbdc17f9fe44ca58443d876eb00f3b"}, diff --git a/pyproject.toml b/pyproject.toml index b2dcd1ab97f..02fb2103691 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -50,7 +50,7 @@ bandit = "^1.7.1" radon = "^5.1.0" xenon = "^0.9.0" flake8-eradicate = "^1.2.1" -flake8-bugbear = "^22.1.11" +flake8-bugbear = "^22.4.25" mkdocs-git-revision-date-plugin = "^0.3.2" mike = "^0.6.0" mypy = "^0.942" From 08c489e3b9c552af32926dfde1722adf57523d94 Mon Sep 17 00:00:00 2001 From: Simon Thulbourn Date: Thu, 28 Apr 2022 14:26:59 +0000 Subject: [PATCH 2/2] fix: change static_pk_value to optional and default of None Flake correctly pointed out that using a dyanmic string will cause issues in an arg. The arg was changed to `Optional[str] = None` instead and a check for `None` is now done, if set to `None`, the old value is used: `idempotency` is used, where name is from a env var --- .../utilities/idempotency/persistence/dynamodb.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py b/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py index 8a470c0f910..88955738ecc 100644 --- a/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py +++ b/aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py @@ -22,7 +22,7 @@ def __init__( self, table_name: str, key_attr: str = "id", - static_pk_value: str = f"idempotency#{os.getenv(constants.LAMBDA_FUNCTION_NAME_ENV, '')}", + static_pk_value: Optional[str] = None, sort_key_attr: Optional[str] = None, expiry_attr: str = "expiration", status_attr: str = "status", @@ -76,6 +76,9 @@ def __init__( if sort_key_attr == key_attr: raise ValueError(f"key_attr [{key_attr}] and sort_key_attr [{sort_key_attr}] cannot be the same!") + if static_pk_value is None: + static_pk_value = f"idempotency#{os.getenv(constants.LAMBDA_FUNCTION_NAME_ENV, '')}" + self._table = None self.table_name = table_name self.key_attr = key_attr