Skip to content

Maintenance: start linting markdown files #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
dreamorosi opened this issue Apr 18, 2024 · 2 comments · Fixed by #2434
Closed
1 of 2 tasks

Maintenance: start linting markdown files #2399

dreamorosi opened this issue Apr 18, 2024 · 2 comments · Fixed by #2434
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

Currently we don't have any linting in place for the documentation.

This leads to inconsistencies when different contributors touch the files, which in some cases lead to increased diff on PRs.

We should take inspiration from the Powertools for AWS Lambda (Python) repo and setup something like (or exactly) markdownlint.

Why is this needed?

So that we can increase consistency and remove cognitive overhead during editing & review.

Which area does this relate to?

Automation

Solution

  • Explore adding markdownlint to the repo
  • Consider adopting most or all the same linting rules that the Python repo uses
  • Set up the tool to run during PRs CI on all markdown files
  • Set up the tool to run on changed files as pre-commit hook

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@dreamorosi dreamorosi added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Apr 18, 2024
@dreamorosi dreamorosi moved this from Triage to Backlog in Powertools for AWS Lambda (TypeScript) Apr 18, 2024
@dreamorosi dreamorosi added good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one labels Apr 18, 2024
@dreamorosi dreamorosi self-assigned this Apr 25, 2024
@dreamorosi dreamorosi moved this from Backlog to Working on it in Powertools for AWS Lambda (TypeScript) Apr 25, 2024
@dreamorosi dreamorosi removed good-first-issue Something that is suitable for those who want to start contributing help-wanted We would really appreciate some support from community for this one labels Apr 25, 2024
@dreamorosi dreamorosi linked a pull request Apr 25, 2024 that will close this issue
9 tasks
@dreamorosi dreamorosi moved this from Working on it to Pending review in Powertools for AWS Lambda (TypeScript) Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in Powertools for AWS Lambda (TypeScript) Apr 25, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Apr 25, 2024
Copy link
Contributor

This is now released under v2.1.1 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels May 14, 2024
@dreamorosi dreamorosi moved this from Coming soon to Shipped in Powertools for AWS Lambda (TypeScript) May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant