Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: [email protected]
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: [email protected]
Choose a head ref
  • 2 commits
  • 10 files changed
  • 2 contributors

Commits on Apr 16, 2025

  1. fix: Symbol.asyncDispose is not defined on the current JavaScript pla…

    …tform (#376)
    
    We have a polyfill file that should be imported before
    `Symbol.asyncDispose` is used anywhere. The polyfill file is imported in
    the entry point of `@aws-cdk/toolkit-lib`, but we can't guarantee that
    all imports go through the entry point.
    
    Instead, import the polyfill in every file where `Symbol.asyncDispose`
    is used.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Apr 16, 2025

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    6b421db View commit details
  2. chore: @aws-cdk/toolkit-lib is now a part of the toolkit packages (#…

    …380)
    
    Until we sort out #364 properly,
    lets at least do this so that toolkit changes trigger a CLI release.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    iliapolo authored Apr 16, 2025
    Copy the full SHA
    af41cf7 View commit details
1 change: 1 addition & 0 deletions .projenrc.ts
Original file line number Diff line number Diff line change
@@ -174,6 +174,7 @@ function transitiveToolkitPackages(thisPkg: string) {
'@aws-cdk/tmp-toolkit-helpers',
'@aws-cdk/cloud-assembly-schema',
'@aws-cdk/cloudformation-diff',
'@aws-cdk/toolkit-lib',
];

return transitiveFeaturesAndFixes(thisPkg, toolkitPackages.filter(name => name !== thisPkg));
4 changes: 2 additions & 2 deletions packages/@aws-cdk/cli-lib-alpha/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/@aws-cdk/integ-runner/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import '../../private/dispose-polyfill';
import type * as cxapi from '@aws-cdk/cx-api';
import { BorrowedAssembly } from './private/borrowed-assembly';
import type { ICloudAssemblySource, IReadableCloudAssembly } from './types';
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import '../../../private/dispose-polyfill';
import type * as cxapi from '@aws-cdk/cx-api';
import type { IReadableCloudAssembly } from '../types';

Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import '../../../private/dispose-polyfill';
import * as os from 'node:os';
import * as path from 'node:path';
import { format } from 'node:util';
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import '../../../private/dispose-polyfill';
import { major } from 'semver';
import type { IoHelper } from '../../shared-private';
import { BaseStackAssembly, StackCollection, ExtendedStackSelection as CliExtendedStackSelection } from '../../shared-private';
@@ -6,11 +7,6 @@ import type { StackSelector } from '../stack-selector';
import { ExpandStackSelection, StackSelectionStrategy } from '../stack-selector';
import type { IReadableCloudAssembly } from '../types';

if (!Symbol.asyncDispose) {
// eslint-disable-next-line @cdklabs/no-throw-default-error
throw new Error('Symbol.asyncDispose is not defined on the current JavaScript platform!');
}

/**
* A single Cloud Assembly wrapped to provide additional stack operations.
*/
1 change: 1 addition & 0 deletions packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import '../private/dispose-polyfill';
import * as path from 'node:path';
import type { TemplateDiff } from '@aws-cdk/cloudformation-diff';
import * as cxapi from '@aws-cdk/cx-api';
4 changes: 2 additions & 2 deletions packages/aws-cdk/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/cdk/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.