Skip to content

Commit 7ea28b0

Browse files
committed
lock to go 1.20.7
recent upgrade of go stable to 1.21.0 has broken the Go plugins. Which are failing in integ with: "morestack on g0" We have not deeply investigated this yet. Waiting on Go community golang/go#62130 (comment) Signed-off-by: Wesley Pettit <[email protected]>
1 parent 8cc9d66 commit 7ea28b0

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

scripts/build_plugins.sh

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,13 @@ fi
166166
# get Go stable version
167167
# Dockerfiles do not allow env vars to be set by commands
168168
# and persist from one command to the next
169-
GO_OUTPUT=$(curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2)
170-
OLD_IFS=$IFS
171-
IFS=$'\n' GO_STABLE_VERSION=($GO_OUTPUT)
172-
IFS=$OLD_IFS
169+
# GO_OUTPUT=$(curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2)
170+
# OLD_IFS=$IFS
171+
# IFS=$'\n' GO_STABLE_VERSION=($GO_OUTPUT)
172+
# IFS=$OLD_IFS
173+
# 2023-08-21: pinning to 1.20.7 go as 1.21.0 fails with FLB
174+
# https://github.com/golang/go/issues/62130#issuecomment-1684431260
175+
export GO_STABLE_VERSION="1.20.7"
173176
echo "Using go:stable version ${GO_STABLE_VERSION}"
174177
PLUGIN_BUILD_ARGS="$PLUGIN_BUILD_ARGS --build-arg GO_STABLE_VERSION=${GO_STABLE_VERSION}"
175178

scripts/dockerfiles/Dockerfile.build

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,12 @@ RUN yum install -y \
3838
--slave /usr/local/bin/ccmake ccmake /usr/bin/ccmake3 \
3939
--family cmake
4040
ENV HOME /home
41+
ENV GO_STABLE_VERSION 1.20.7
4142

4243
# Lock Go Lang version to stable
43-
RUN export GO_STABLE_OUTPUT=`curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2`; \
44-
IFS=$'\n' GO_STABLE_VERSION=($GO_STABLE_OUTPUT); \
45-
echo "Using go:stable version ${GO_STABLE_VERSION}"; \
44+
# RUN export GO_STABLE_OUTPUT=`curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2`; \
45+
# IFS=$'\n' GO_STABLE_VERSION=($GO_STABLE_OUTPUT); \
46+
RUN echo "Using go:stable version ${GO_STABLE_VERSION}"; \
4647
gimme ${GO_STABLE_VERSION}; \
4748
ln -s /home/.gimme/versions/go${GO_STABLE_VERSION}.linux.arm64 /home/.gimme/versions/gostable.linux.arm64; \
4849
ln -s /home/.gimme/versions/go${GO_STABLE_VERSION}.linux.amd64 /home/.gimme/versions/gostable.linux.amd64

scripts/dockerfiles/Dockerfile.build-init

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,12 @@ RUN curl -sL -o /bin/gimme https://github.com/raw/travis-ci/gimme/mas
44
RUN chmod +x /bin/gimme
55
RUN yum upgrade -y && yum install -y tar gzip git
66
ENV HOME /home
7+
ENV GO_STABLE_VERSION 1.20.7
78

89
# Lock Go Lang version to stable
9-
RUN export GO_STABLE_OUTPUT=`curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2`; \
10-
IFS=$'\n' GO_STABLE_VERSION=($GO_STABLE_OUTPUT); \
11-
echo "Using go:stable version ${GO_STABLE_VERSION}"; \
10+
# RUN export GO_STABLE_OUTPUT=`curl --silent https://go.dev/VERSION?m=text | cut -d "o" -f 2`; \
11+
# IFS=$'\n' GO_STABLE_VERSION=($GO_STABLE_OUTPUT); \
12+
RUN echo "Using go:stable version ${GO_STABLE_VERSION}"; \
1213
gimme ${GO_STABLE_VERSION}; \
1314
ln -s /home/.gimme/versions/go${GO_STABLE_VERSION}.linux.arm64 /home/.gimme/versions/gostable.linux.arm64; \
1415
ln -s /home/.gimme/versions/go${GO_STABLE_VERSION}.linux.amd64 /home/.gimme/versions/gostable.linux.amd64

0 commit comments

Comments
 (0)