From b6d5b07927cf449ca75cc69a1f864d2e84eb5044 Mon Sep 17 00:00:00 2001
From: Archit Aggarwal <architag@amazon.com>
Date: Wed, 12 Aug 2020 17:28:45 +0000
Subject: [PATCH] Address unused parameter and unused variable warnings

---
 .../mqtt/utest/mqtt_lightweight_utest.c        | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/libraries/standard/mqtt/utest/mqtt_lightweight_utest.c b/libraries/standard/mqtt/utest/mqtt_lightweight_utest.c
index 0d2f973338..6f00cbeaa1 100644
--- a/libraries/standard/mqtt/utest/mqtt_lightweight_utest.c
+++ b/libraries/standard/mqtt/utest/mqtt_lightweight_utest.c
@@ -182,6 +182,11 @@ static int32_t mockReceiveNoData( NetworkContext_t * pNetworkContext,
                                   void * pBuffer,
                                   size_t bytesToRecv )
 {
+    /* Suppress unused parameter warning. */
+    ( void ) pNetworkContext;
+    ( void ) pBuffer;
+    ( void ) bytesToRecv;
+
     return 0;
 }
 
@@ -192,6 +197,11 @@ static int32_t mockReceiveFailure( NetworkContext_t * pNetworkContext,
                                    void * pBuffer,
                                    size_t bytesToRecv )
 {
+    /* Suppress unused parameter warning. */
+    ( void ) pNetworkContext;
+    ( void ) pBuffer;
+    ( void ) bytesToRecv;
+
     return -1;
 }
 
@@ -736,7 +746,6 @@ void test_MQTT_SerializeSubscribe( void )
     MQTTSubscribeInfo_t subscriptionList;
     size_t subscriptionCount = 1;
     size_t remainingLength = 0;
-    uint16_t packetIdentifier;
     uint8_t buffer[ 25 + 2 * BUFFER_PADDING_LENGTH ];
     size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
     size_t packetSize = bufferSize;
@@ -845,7 +854,6 @@ void test_MQTT_SerializeUnsubscribe( void )
     MQTTSubscribeInfo_t subscriptionList;
     size_t subscriptionCount = 1;
     size_t remainingLength = 0;
-    uint16_t packetIdentifier;
     uint8_t buffer[ 25 + 2 * BUFFER_PADDING_LENGTH ];
     size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
     size_t packetSize = bufferSize;
@@ -1011,8 +1019,6 @@ void test_MQTT_SerializePublish( void )
 {
     MQTTPublishInfo_t publishInfo;
     size_t remainingLength = 98;
-    uint16_t packetIdentifier;
-    uint8_t * pPacketIdentifierHigh;
     uint8_t buffer[ 200 + 2 * BUFFER_PADDING_LENGTH ];
     size_t bufferSize = sizeof( buffer ) - 2 * BUFFER_PADDING_LENGTH;
     size_t packetSize = bufferSize;
@@ -1525,7 +1531,6 @@ void test_MQTT_DeserializePublish( void )
 
     size_t remainingLength = 0;
     uint16_t packetIdentifier;
-    uint8_t * pPacketIdentifierHigh;
 
     fixedBuffer.pBuffer = buffer;
     fixedBuffer.size = bufferSize;
@@ -1761,8 +1766,6 @@ void test_MQTT_SerializePublishHeader( void )
 {
     MQTTPublishInfo_t publishInfo;
     size_t remainingLength = 0;
-    uint16_t packetIdentifier;
-    uint8_t * pPacketIdentifierHigh;
     uint8_t buffer[ 200 + 2 * BUFFER_PADDING_LENGTH ];
     uint8_t expectedPacket[ 200 ];
     uint8_t * pIterator;
@@ -2324,7 +2327,6 @@ void test_MQTT_SerializeDisconnect_Invalid_Params()
 void test_MQTT_SerializeDisconnect_Happy_Path()
 {
     MQTTStatus_t mqttStatus = MQTTSuccess;
-    size_t packetSize = 0;
     MQTTFixedBuffer_t networkBuffer;
 
     /* Fill structs to pass into methods to be tested. */