Add file overload to DownloadRequest and UploadRequest (#2707)

* Add file overload to DownloadRequest and UploadRequest

* Address comments

Author: zoewangg

.changes/next-release/feature-S3TransferManager-a6fd00b.json

@@ -0,0 +1,6 @@
+{
+    "category": "S3 Transfer Manager", 
+    "contributor": "", 
+    "type": "feature", 
+    "description": "Now users can pass `File` to `DownloadRequest` and `UploadRequest` in `S3TransferManager`."
+}

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/DownloadRequest.java

@@ -15,6 +15,7 @@
 
 package software.amazon.awssdk.transfer.s3;
 
+import java.io.File;
 import java.nio.file.Path;
 import java.util.Objects;
 import java.util.function.Consumer;
@@ -112,6 +113,18 @@ public interface Builder extends TransferRequest.Builder<DownloadRequest, Builde
          */
         Builder destination(Path destination);
 
+        /**
+         * The file that response contents will be written to. The file must not exist or this method
+         * will throw an exception. If the file is not writable by the current user then an exception will be thrown.
+         *
+         * @param destination the destination path
+         * @return Returns a reference to this object so that method calls can be chained together.
+         */
+        default Builder destination(File destination) {
+            Validate.paramNotNull(destination, "destination");
+            return destination(destination.toPath());
+        }
+
         /**
          * The {@link GetObjectRequest} request that should be used for the download
          *

services-custom/s3-transfer-manager/src/main/java/software/amazon/awssdk/transfer/s3/UploadRequest.java

@@ -17,13 +17,15 @@
 
 import static software.amazon.awssdk.utils.Validate.paramNotNull;
 
+import java.io.File;
 import java.nio.file.Path;
 import java.util.Objects;
 import java.util.function.Consumer;
 import software.amazon.awssdk.annotations.NotThreadSafe;
 import software.amazon.awssdk.annotations.SdkPreviewApi;
 import software.amazon.awssdk.annotations.SdkPublicApi;
 import software.amazon.awssdk.services.s3.model.PutObjectRequest;
+import software.amazon.awssdk.utils.Validate;
 import software.amazon.awssdk.utils.builder.CopyableBuilder;
 import software.amazon.awssdk.utils.builder.ToCopyableBuilder;
 
@@ -112,6 +114,19 @@ public interface Builder extends TransferRequest.Builder<UploadRequest, Builder>
          */
         Builder source(Path source);
 
+        /**
+         * The file containing data to send to the service. File will be read entirely and may be read
+         * multiple times in the event of a retry. If the file does not exist or the current user does not have
+         * access to read it then an exception will be thrown.
+         *
+         * @param source the source path
+         * @return Returns a reference to this object so that method calls can be chained together.
+         */
+        default Builder source(File source) {
+            Validate.paramNotNull(source, "source");
+            return this.source(source.toPath());
+        }
+
         /**
          * Configure the {@link PutObjectRequest} that should be used for the upload
          *

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/DownloadRequestTest.java

@@ -17,6 +17,8 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import java.io.File;
+import java.nio.file.Path;
 import java.nio.file.Paths;
 import org.junit.Rule;
 import org.junit.Test;
@@ -48,6 +50,29 @@ public void pathMissing_throws() {
                        .build();
     }
 
+    @Test
+    public void usingFile() {
+        Path path = Paths.get(".");
+        DownloadRequest requestUsingFile = DownloadRequest.builder()
+                                                          .getObjectRequest(b -> b.bucket("bucket").key("key"))
+                                                          .destination(path.toFile())
+                                                          .build();
+
+        assertThat(requestUsingFile.destination()).isEqualTo(path);
+    }
+
+    @Test
+    public void usingFile_null_shouldThrowException() {
+        thrown.expect(NullPointerException.class);
+        thrown.expectMessage("destination");
+        File file = null;
+        DownloadRequest.builder()
+                       .getObjectRequest(b -> b.bucket("bucket").key("key"))
+                       .destination(file)
+                       .build();
+
+    }
+
     @Test
     public void equals_hashcode() {
         GetObjectRequest getObjectRequest = GetObjectRequest.builder()

services-custom/s3-transfer-manager/src/test/java/software/amazon/awssdk/transfer/s3/UploadRequestTest.java

@@ -17,6 +17,8 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
+import java.io.File;
+import java.nio.file.Path;
 import java.nio.file.Paths;
 import org.junit.Rule;
 import org.junit.Test;
@@ -46,6 +48,27 @@ public void pathMissing_shouldThrow() {
                      .build();
     }
 
+    @Test
+    public void sourceUsingFile() {
+        Path path = Paths.get(".");
+        UploadRequest request = UploadRequest.builder()
+                                             .putObjectRequest(b -> b.bucket("bucket").key("key"))
+                                             .source(path.toFile())
+                                             .build();
+        assertThat(request.source()).isEqualTo(path);
+    }
+
+    @Test
+    public void sourceUsingFile_null_shouldThrowException() {
+        File file = null;
+        thrown.expect(NullPointerException.class);
+        thrown.expectMessage("source");
+        UploadRequest.builder()
+                     .putObjectRequest(b -> b.bucket("bucket").key("key"))
+                     .source(file)
+                     .build();
+    }
+
     @Test
     public void equals_hashcode() {
         PutObjectRequest getObjectRequest = PutObjectRequest.builder()