From d189130be90048599ec098576c4c56d4b23d8275 Mon Sep 17 00:00:00 2001 From: David Thomas Date: Tue, 22 Nov 2022 05:02:10 -0800 Subject: [PATCH 1/3] When inferring task, open config.json for reading only. --- .../transformers_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sagemaker_huggingface_inference_toolkit/transformers_utils.py b/src/sagemaker_huggingface_inference_toolkit/transformers_utils.py index b5282c4..36517b9 100644 --- a/src/sagemaker_huggingface_inference_toolkit/transformers_utils.py +++ b/src/sagemaker_huggingface_inference_toolkit/transformers_utils.py @@ -211,7 +211,7 @@ def infer_task_from_model_architecture(model_config_path: str, architecture_inde trainend on different tasks https://huggingface.co/facebook/bart-large/blob/main/config.json. Should work for every on Amazon SageMaker fine-tuned model. It is always recommended to set the task through the env var `TASK`. """ - with open(model_config_path, "r+") as config_file: + with open(model_config_path, "r") as config_file: config = json.loads(config_file.read()) architecture = config.get("architectures", [None])[architecture_index] From 519fc5421eb3a27cf7bb9f1e815345f0d974b1d6 Mon Sep 17 00:00:00 2001 From: David Thomas Date: Sat, 26 Nov 2022 04:43:17 -0800 Subject: [PATCH 2/3] Update CI to use Python 3.7. There's an open issue with setup-python action with Python 3.6 on Ubuntu. For details, see https://github.com/actions/setup-python/issues/544 --- .github/workflows/integ-test.yml | 4 ++-- .github/workflows/quality.yml | 4 ++-- .github/workflows/unit-test.yml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/integ-test.yml b/.github/workflows/integ-test.yml index 7beab15..3906b98 100644 --- a/.github/workflows/integ-test.yml +++ b/.github/workflows/integ-test.yml @@ -10,10 +10,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Set up Python 3.6 + - name: Set up Python 3.7 uses: actions/setup-python@v2 with: - python-version: 3.6 + python-version: 3.7 - name: Install Python dependencies run: pip install -e .[test,dev] - name: Run Integration Tests diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml index 9b54a26..1a59089 100644 --- a/.github/workflows/quality.yml +++ b/.github/workflows/quality.yml @@ -7,10 +7,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Set up Python 3.6 + - name: Set up Python 3.7 uses: actions/setup-python@v2 with: - python-version: 3.6 + python-version: 3.7 - name: Install Python dependencies run: pip install -e .[quality] - name: Run Quality check diff --git a/.github/workflows/unit-test.yml b/.github/workflows/unit-test.yml index 2899375..847ec70 100644 --- a/.github/workflows/unit-test.yml +++ b/.github/workflows/unit-test.yml @@ -7,10 +7,10 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - - name: Set up Python 3.6 + - name: Set up Python 3.7 uses: actions/setup-python@v2 with: - python-version: 3.6 + python-version: 3.7 - name: Install Python dependencies run: pip install -e .[test,dev] - name: Run Unit Tests From d137b216b48dcb879de298690a4103358284a0bf Mon Sep 17 00:00:00 2001 From: David Thomas Date: Sat, 26 Nov 2022 05:02:13 -0800 Subject: [PATCH 3/3] Set upperbound fo tensorflow version in extras["dev"] since it breaks current versions of transformers. See https://github.com/huggingface/evaluate/pull/372 --- setup.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 030fb43..62e691f 100644 --- a/setup.py +++ b/setup.py @@ -58,7 +58,9 @@ # framework specific dependencies extras["torch"] = ["torch>=1.8.0", "torchaudio"] -extras["tensorflow"] = ["tensorflow>=2.4.0"] + +# TODO: Remove upper bound of TF 2.11 once transformers release contains this fix: https://github.com/huggingface/evaluate/pull/372 +extras["tensorflow"] = ["tensorflow>=2.4.0,<2.11"] # MMS Server dependencies extras["mms"] = ["multi-model-server>=1.1.4", "retrying"]